Bug 1377316

Summary:	[RFE] make _remote_ vim doing the right decisions about 'set background'
Product:	Red Hat Enterprise Linux 7	Reporter:	Pavel Raiskup <praiskup>
Component:	vim	Assignee:	Zdenek Dohnal <zdohnal>
Status:	CLOSED ERRATA	QA Contact:	Patrik Moško <pmosko>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.4	CC:	extras-qa, jjelen, jkejda, karsten, kdudka, lrintel, mkolaja, moshima.web, pmosko, praiskup, psklenar, thozza
Target Milestone:	rc	Keywords:	FutureFeature, Patch
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	vim-7.4.629-2.el7	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	1262837	Environment:
Last Closed:	2019-08-06 12:45:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1262837, 1262843, 1262863, 1264682
Bug Blocks:	1551022, 1630913

Description Pavel Raiskup 2016-09-19 12:31:18 UTC

I always run commands in "dark" terminal, and doing ssh from (sufficiently
new) box to RHEL 7 box causes, that running 'vim' on RHEL7 still thinks
that the background color is "light".  With Fedora this works fine.

There is defined terminal protocol so vim is able to communicate the
background color with terminal (be that local or remote terminal over ssh).
Upstream (and Fedora) vim has this already implemented, and it would be nice
to have this backported into RHEL7:

https://github.com/vim/vim/commit/f71d7b9ee5ceba75f70c30845332ddd728fd16c6

Also have a look at bug 1159920.

+++ This bug was initially created as a clone of Bug #1262837 +++

Comment 1 Pavel Raiskup 2016-09-19 12:36:16 UTC

I'm sorry, I've posted wrong patch link, this should be correct:
https://github.com/vim/vim/commit/b5c3265521749fda81ae4b052de35a0d1209cf50

Comment 4 Pavel Raiskup 2018-03-28 12:50:40 UTC

Ping.  Being 2018 now, administrators are going to take care of RHEL7 boxes
for a very long time;  so fixing this still makes sense IMO.  It would make
the work with remote RHEL7 boxes much more convenient *by default* (for
administrators with dark terminal).

Comment 13 Pavel Raiskup 2019-01-23 09:35:48 UTC

I've just tested 7.4.629-2.el7.x86_64, and it works perfectly, thank you.

Comment 14 Kamil Dudka 2019-05-16 11:11:31 UTC

(In reply to Pavel Raiskup from comment #13)
> I've just tested 7.4.629-2.el7.x86_64, and it works perfectly, thank you.

Yes, vim-7.4.629-2.el7 works as expected.  Good job.  Thank both of you!

Comment 18 errata-xmlrpc 2019-08-06 12:45:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2098