Bug 1377320

Summary:	Azure Compute Resource: Move to strong-params
Product:	Red Hat Satellite	Reporter:	Sachin Ghai <sghai>
Component:	Compute Resources - Azure	Assignee:	Daniel Lobato Garcia <dlobatog>
Status:	CLOSED UPSTREAM	QA Contact:	Katello QA List <katello-qa-list>
Severity:	medium	Docs Contact:
Priority:	high
Version:	6.3.0	CC:	bbuckingham, bkearney, dlobatog, ehelms, kbidarka
Target Milestone:	Unspecified	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
URL:	http://projects.theforeman.org/issues/16269
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-30 20:00:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sachin Ghai 2016-09-19 12:36:50 UTC

Currently installing the "foreman-azure" package on RHEL7 throws the below trace-back.

ForemanAzure::Azure is using attr_accessible so must either be converted to strong parameters, or add the protected_attributes gem (RuntimeError)
  /usr/share/foreman/config/initializers/active_record_extensions.rb:21:in `attr_accessible'
  /usr/share/foreman/app/models/concerns/optional_attr_accessible.rb:30:in `attr_accessible'
  /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:5:in `<class:Azure>'
  /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:2:in `<module:ForemanAzure>'
  /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:1:in `<top (required)>'
  /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'
  /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'
  /opt/rh/sclo-ror42/root/usr/share/gems/gems/polyglot-0.3.4/lib/polyglot.rb:65:in `require'


1) Installed setup using katello-deploy and RHEL7 UI Was accessible with latest nightly.
2) Installed Azure CR via "yum install foreman-azure"
3) Restarted the katello-service and found the above issue related to Foreman:Azure

Comment 1 Sachin Ghai 2016-09-19 12:36:55 UTC

Created from redmine issue http://projects.theforeman.org/issues/16269

Comment 2 Sachin Ghai 2016-09-19 12:38:03 UTC

Connecting redmine issue http://projects.theforeman.org/issues/16269 from this bug

Comment 3 Sachin Ghai 2016-09-19 12:45:22 UTC

I see the similar issue with sat6.3 snap1:

tfm-rubygem-azure-core-0.1.1-1.el7.noarch
tfm-rubygem-azure-0.7.5-1.el7.noarch 
tfm-rubygem-fog-azure-0.0.2-1.el7.noarch 
tfm-rubygem-foreman_azure-1.0.1-1.fm1_13.el7.noarch
satellite-installer-6.3.0.0-1.git.12.695b530.el7sat.noarch


| RuntimeError: ForemanAzure::Azure is using attr_accessible so must either be converted to strong parameters, or add the protected_attributes gem
 | /usr/share/foreman/config/initializers/active_record_extensions.rb:21:in `attr_accessible'
 | /usr/share/foreman/app/models/concerns/optional_attr_accessible.rb:30:in `attr_accessible'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:5:in `<class:Azure>'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:2:in `<module:ForemanAzure>'
 | /opt/theforeman/tfm/root/usr/share/gems/gems/foreman_azure-1.0.1/app/models/foreman_azure/azure.rb:1:in `<top (required)>'
 | /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'
 | /opt/rh/rh-ruby22/root/usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in `require'

Comment 6 Bryan Kearney 2016-10-03 16:19:53 UTC

Upstream bug assigned to dlobatog

Comment 7 Bryan Kearney 2016-10-03 16:19:56 UTC

Moving this bug to POST for triage into Satellite 6 since the upstream issue http://projects.theforeman.org/issues/16269 has been resolved.

Comment 8 Daniel Lobato Garcia 2016-12-09 10:52:27 UTC

No longer need info from me