Bug 1377386
Summary: | glusterd experiencing repeated connect/disconnect messages when shd is down | |||
---|---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Atin Mukherjee <amukherj> | |
Component: | protocol | Assignee: | Atin Mukherjee <amukherj> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
Severity: | medium | Docs Contact: | ||
Priority: | medium | |||
Version: | 3.9 | CC: | amukherj, bugs, jdarcy, kaushal, ravishankar, rgowdapp | |
Target Milestone: | --- | Keywords: | Triaged | |
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | glusterfs-3.9.0 | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | ||
Clone Of: | 1372356 | |||
: | 1378130 (view as bug list) | Environment: | ||
Last Closed: | 2016-12-06 05:59:41 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1372356, 1377387 | |||
Bug Blocks: | 1373723, 1378130 |
Description
Atin Mukherjee
2016-09-19 14:31:59 UTC
REVIEW: http://review.gluster.org/15533 (socket: pollerr event shouldn't trigger socket_connnect_finish) posted (#1) for review on release-3.9 by Atin Mukherjee (amukherj) COMMIT: http://review.gluster.org/15533 committed in release-3.9 by Pranith Kumar Karampuri (pkarampu) ------ commit b4ed6127675eeed74264a151132bc1bce8dd921c Author: Atin Mukherjee <amukherj> Date: Thu Sep 8 11:33:59 2016 +0530 socket: pollerr event shouldn't trigger socket_connnect_finish If connect fails with any other error than EINPROGRESS we cannot get the error status using getsockopt (... SO_ERROR ... ). Hence we need to remember the state of connect and take appropriate action in the event_handler for the same. As an added note, a event can come where poll_err is HUP and we have poll_in as well (i.e some status was written to the socket), so for such cases we need to finish the connect, process the data and then the poll_err as is the case in the current code. Special thanks to Kaushal M & Raghavendra G for figuring out the issue. >Signed-off-by: Shyam <srangana> >Reviewed-on: http://review.gluster.org/15440 >Smoke: Gluster Build System <jenkins.org> >NetBSD-regression: NetBSD Build System <jenkins.org> >CentOS-regression: Gluster Build System <jenkins.org> >Reviewed-by: Raghavendra G <rgowdapp> Change-Id: Ic45ad59ff8ab1d0a9d2cab2c924ad940b9d38528 BUG: 1377386 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/15533 Smoke: Gluster Build System <jenkins.org> NetBSD-regression: NetBSD Build System <jenkins.org> CentOS-regression: Gluster Build System <jenkins.org> Reviewed-by: Pranith Kumar Karampuri <pkarampu> glusterfs-3.9.0rc2 is released[1] and packages are available for different distributions[2] to test. [1] http://www.gluster.org/pipermail/maintainers/2016-October/001601.html [2] http://www.gluster.org/pipermail/maintainers/2016-October/001605.html and http://www.gluster.org/pipermail/maintainers/2016-October/001606.html Gluster 3.9 GA is released http://blog.gluster.org/2016/11/announcing-gluster-3-9/ |