Bug 1377547

Summary: Notification feature in rear
Product: Red Hat Enterprise Linux 7 Reporter: ajit mote <amote>
Component: rearAssignee: Jakub Mazanek <jmazanek>
Status: CLOSED ERRATA QA Contact: Tereza Cerna <tcerna>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.2CC: jmazanek, ovasik, phracek, tcerna
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
undefined
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 22:19:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1298243, 1393870, 1400961    

Description ajit mote 2016-09-20 05:30:49 UTC
Description of problem:
Once backup is completed (rear mkbackup), customer would like to log message that "backup complete" with a timestamp and location of the backup so the result can be inserted into a database. 

Version-Release number of selected component (if applicable):
rear-1.17.2-1.el7.noarch

How reproducible:
Always

Steps to Reproduce:
Currently there is no provision to log message after successful backup completion.

Actual results:
Currently there is no provision to log message after successful backup completion.

Expected results:
Have some kind of provision to log message after successful backup completion only.

Additional info:
As a temporary hack, I modified /usr/sbin/rear bash script itself to log such message.

# Check for and run the requested workflow
if has_binary WORKFLOW_$WORKFLOW; then
        Log "Running $WORKFLOW workflow"
        WORKFLOW_$WORKFLOW "${ARGS[@]}"
        Log "Finished running $WORKFLOW workflow $BACKUP_URL"
        LogPrint "Finished running $WORKFLOW workflow $BACKUP_URL `date` " <<<<<< Added this line to print any messages and access variables 
else
        VERBOSE=1
        LogPrint "ERROR: The specified command '$WORKFLOW' does not exist !"
        EXIT_CODE=1
fi

I have not completely tested above but looks possible to get notification from here.

Comment 3 Petr Hracek 2016-10-04 08:41:45 UTC
I would prefer to create a Pull Request to upstream.
Relevant issue for it is: https://github.com/rear/rear/issues/1023
Relevant upstream Pull Request: https://github.com/rear/rear/pull/1022

We will see whether upstream accept it.

Comment 4 ajit mote 2016-10-04 08:52:16 UTC
(In reply to Petr Hracek from comment #3)
> I would prefer to create a Pull Request to upstream.
> Relevant issue for it is: https://github.com/rear/rear/issues/1023
> Relevant upstream Pull Request: https://github.com/rear/rear/pull/1022
> 
> We will see whether upstream accept it.

Thanks. hopefully it will get merge upstream and then downstream a well.

Comment 10 Petr Hracek 2016-10-19 11:57:02 UTC
See upstream comments and feel free to comment it.
https://github.com/rear/rear/pull/1022

Comment 11 ajit mote 2016-10-20 06:08:09 UTC
(In reply to Petr Hracek from comment #10)
> See upstream comments and feel free to comment it.
> https://github.com/rear/rear/pull/1022

Thanks.

Comment 13 Jakub Mazanek 2017-02-23 14:55:21 UTC
rebase to rear-2.00 will fix this issue

Comment 19 errata-xmlrpc 2017-08-01 22:19:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2052