Bug 137755
Summary: | /etc/hotplug/blacklist matches when it shouldn't | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jonathan Kamens <jik> |
Component: | initscripts | Assignee: | Bill Nottingham <notting> |
Status: | CLOSED RAWHIDE | QA Contact: | Brock Organ <borgan> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | rvokal |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 7.95-1 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2004-11-01 22:40:40 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jonathan Kamens
2004-11-01 02:03:37 UTC
Do modules actually use regexp characters? The awk solution is rather more inefficient. fgrep -xq seems simpler (and faster). Added, will be in later releases. (7.95-1, at least) Concerning the speed of awk: There aren't enough modules to make the speed terribly relevant, not to mention the fact that this only happens once, at boot. Concerning whether the module names may contain regexp chars: Unless you can be 100% certain that the input into this function will never contain regexp chars (remember, e.g., that even "." is a regexp charge, and I don't think it's unimaginable for a module name to have a period in it), I think you need to write the code to be resistent to them. Concerning fgrep -xq: It is not forgiving of lines with extra whitespace at the beginning or end, which I believe it should be, whereas the awk code is. I don't think this is the best implementation. From the upstream blacklist file: # Syntax: driver name alone (without any spaces) on a line. Other # lines are ignored. Ergo, space is not an issue. At this point, the rc.sysinit is at least bug-compatible with upstream hotplug. |