| Summary: | Above sea level is in 'km' instead of 'm' in tooltip | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> | ||||||||||
| Component: | xfce4-weather-plugin | Assignee: | Christoph Wickert <christoph.wickert> | ||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||
| Priority: | unspecified | ||||||||||||
| Version: | 24 | CC: | christoph.wickert, nonamedotc, robyduck | ||||||||||
| Target Milestone: | --- | ||||||||||||
| Target Release: | --- | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Whiteboard: | |||||||||||||
| Fixed In Version: | xfce4-weather-plugin-0.8.8-2.fc25 xfce4-weather-plugin-0.8.8-2.fc24 | Doc Type: | If docs needed, set a value | ||||||||||
| Doc Text: | Story Points: | --- | |||||||||||
| Clone Of: | Environment: | ||||||||||||
| Last Closed: | 2016-10-11 15:42:40 UTC | Type: | Bug | ||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||
| Documentation: | --- | CRM: | |||||||||||
| Verified Versions: | Category: | --- | |||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||
| Attachments: |
|
||||||||||||
Created attachment 1202850 [details]
Settings dialog
Created attachment 1203090 [details]
screenshot from my system
That's very strange ..
See the attached screenshot from my system - it does seem to show the correct units.
What version of xfce4-weather-plugin do you have installed? the latest from repos?
I wonder if this is something that crept through in translation (typoish) .. likely? Created attachment 1203373 [details]
Proposed fix
Yes, it seems it's typo in the translation. I think the attached patch is correct (but I haven't check it yet, I will check it later today.
Sorry about the wrong NVR in the report, copy and paste error from different bug :)
xfce4-weather-plugin-0.8.8-1.fc24.x86_64
The patch seems to also apply over the rawhide.
The proposed patch fixed the problem for me. Thanks for the patch. I will push this soon (tomorrow most likely) and also submit this upstream. Can you install this and verify that the patch has applied cleanly? http://koji.fedoraproject.org/koji/buildinfo?buildID=805859 Thanks. (In reply to Mukundan Ragavan from comment #7) > Can you install this and verify that the patch has applied cleanly? > > http://koji.fedoraproject.org/koji/buildinfo?buildID=805859 > > > Thanks. Thanks, I can confirm the build fixed the problem for me. xfce4-weather-plugin-0.8.8-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9b39bffdbb xfce4-weather-plugin-0.8.8-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa38ea6337 xfce4-weather-plugin-0.8.8-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. xfce4-weather-plugin-0.8.8-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 1202849 [details] Wrong display Description of problem: In the settings dialog the above sea level (ASL) is in meters (m), but in the tooltip the same number is suffixed as kilometers (km). See screenshots for details. I was able to reproduce this in Czech locale, I didn't try different locales. Version-Release number of selected component (if applicable): xfce4-screenshooter-1.8.2-6.fc24.x86_64 How reproducible: Always Steps to Reproduce: 1. Compare settings dialog and tooltip Actual results: In settings dialog the number is in meters (correct), but in the tooltip it's displayed as kilometers (incorrect). Expected results: Both displayed in meters. Additional info: