Bug 1377718

Summary:	delete corrupted downloads
Product:	[Fedora] Fedora	Reporter:	Kamil Páral <kparal>
Component:	mediawriter	Assignee:	Martin Bříza <mbriza>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	25	CC:	mbriza
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	mediawriter-3.97.1-0.fc25	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-27 00:31:45 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kamil Páral 2016-09-20 12:43:16 UTC

Description of problem:
Currently if checksum verification fails, and you hit Retry, it _writes_ that image onto the stick. It should instead retry the download. Also, if you quit and restart mediawriter in the meantime, no further verification is performed, and again the (corrupted) image is written. I think that is confusing to the user and very error-prone.

It would be much easier if you simply deleted the image immediately if the checksum verification fails. That would also probably make the Retry button work properly.

Version-Release number of selected component (if applicable):
mediawriter-3.96.0-0.fc25.x86_64

How reproducible:
always

Steps to Reproduce:
1. echo "broken" > ~/Download/Fedora-Workstation-Live-x86_64-24-1.2.iso.part
2. download the rest of the image using mediawriter
3. see "verification failed" error
4. click Retry button
5. see "Ready to write" message immediately

Comment 1 Martin Bříza 2016-09-20 12:47:35 UTC

Based on your report, I fixed this upstream. Thank you.

Comment 2 Fedora Update System 2016-09-23 05:24:20 UTC

mediawriter-3.97.0-0.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d84f684d42

Comment 3 Kamil Páral 2016-09-23 13:02:04 UTC

This seems to work for the reproducer in comment 0, however it didn't work for me when I did this:

$ truncate -s 1540000000 Fedora-Workstation-Live-x86_64-24-1.2.iso.part

The image was "ready to write" after downloading the few missing MBs. Martin said it works well for him with 3.97.1, I'll wait for the new version and try it.

Comment 4 Kamil Páral 2016-09-23 13:47:55 UTC

(In reply to Kamil Páral from comment #3)
> This seems to work for the reproducer in comment 0, however it didn't work
> for me when I did this:
> 
> $ truncate -s 1540000000 Fedora-Workstation-Live-x86_64-24-1.2.iso.part

This works well for me ("image is corrupted") with mediawriter-3.97.1-0.fc25.

Comment 5 Fedora Update System 2016-09-24 17:52:07 UTC

mediawriter-3.97.1-0.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e34fd77aaf

Comment 6 Fedora Update System 2016-09-27 00:31:45 UTC

mediawriter-3.97.1-0.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.