Bug 1377740

Summary: Add pNFS READs and WRITEs to the mountstats program output
Product: Red Hat Enterprise Linux 7 Reporter: Scott Mayhew <smayhew>
Component: nfs-utilsAssignee: Steve Dickson <steved>
Status: CLOSED ERRATA QA Contact: Yongcheng Yang <yoyang>
Severity: low Docs Contact:
Priority: low    
Version: 7.3CC: dwysocha, eguan, yoyang
Target Milestone: rcKeywords: FutureFeature, Patch, Reproducer
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: nfs-utils-1.3.0-0.34.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 19:48:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1385242    
Attachments:
Description Flags
patch none

Description Scott Mayhew 2016-09-20 13:55:57 UTC
Description of problem:

The counters have been present in /proc/self/mountstats for a while.  They're the last 2 counters on the 'events' line.  We might as well display them in the mountstats output.

Version-Release number of selected component (if applicable):

nfs-utils-1.3.0-0.21.el7_2.1

How reproducible:
easy

Steps to Reproduce:
1. mount a pNFS-capable export
2. do some I/O
3. run 'mountstats --nfs <mountpoint>'


Expected results:

pNFS read and write counts should be included in the output

Comment 1 Scott Mayhew 2016-09-20 13:56:59 UTC
Created attachment 1202902 [details]
patch

Comment 2 Scott Mayhew 2016-09-20 13:57:29 UTC
[root@tonberry ~]# mountstats --nfs /mnt/t
Stats for netapp-gss2.lab.bos.redhat.com:/ mounted on /mnt/t:
  NFS mount options: rw,vers=4.1,rsize=65536,wsize=65536,namlen=255,acregmin=3,acregmax=60,acdirmin=30,acdirmax=60,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=10.13.145.110,local_lock=none
  NFS server capabilities: caps=0x3ffd7,wtmult=512,dtsize=32768,bsize=0,namlen=255
  NFSv4 capability flags: bm0=0xfafe8fff,bm1=0x60fdfffe,bm2=0x817,acl=0x0,sessions,pnfs=LAYOUT_NFSV4_1_FILES
  NFS security flavor: 1  pseudoflavor: 0

Cache events:
  data cache invalidated 2 times
  attribute cache invalidated 2 times

VFS calls:
  VFS requested 8 inode revalidations
  VFS requested 51 dentry revalidations

  VFS called nfs_readdir() 6 times
  VFS called nfs_lookup() 3 times
  VFS called nfs_permission() 64 times
  VFS called nfs_file_open() 3 times
  VFS called nfs_file_flush() 3 times
  VFS called nfs_lock() 0 times
  VFS called nfs_fsync() 2 times
  VFS called nfs_file_release() 2 times

VM calls:
  VFS called nfs_readpage() 1 times
  VFS called nfs_readpages() 56 times
  VFS called nfs_writepage() 0 times
  VFS called nfs_writepages() 4 times

Generic NFS counters:
  File size changing operations:
    truncating SETATTRs: 0  extending WRITEs: 25600
  0 silly renames
  short reads: 0  short writes: 0
  NFSERR_DELAYs from server: 0
  pNFS READs: 1600
  pNFS WRITEs: 1600

NFS byte counts:
  applications read 104857600 bytes via read(2)
  applications wrote 104857600 bytes via write(2)
  applications read 0 bytes via O_DIRECT read(2)
  applications wrote 0 bytes via O_DIRECT write(2)
  client read 104857600 bytes via NFS READ
  client wrote 104857600 bytes via NFS WRITE

Comment 3 Steve Dickson 2016-09-22 17:36:12 UTC
The upstream commit:

commit 3e2ab78a2cfbc2d11c31ced8d3f538d5aae757f1
Author: Scott Mayhew <smayhew>
Date:   Thu Sep 22 13:33:33 2016 -0400

    mountstats: add pNFS READs and WRITEs
    
    These counters are already in /proc/self/mountstats but the mountstats
    program doesn't display them.
    
    Signed-off-by: Scott Mayhew <smayhew>
    Signed-off-by: Steve Dickson <steved>
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1377740

Comment 7 Yongcheng Yang 2017-04-19 05:39:32 UTC
Moving to VERIFIED according to test logs in Comment #6.

Comment 8 errata-xmlrpc 2017-08-01 19:48:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2233