Bug 1377758

This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

> /usr/share/ovirt-engine/setup/bin/ovirt-engine-rename
> --newname=jenkins-vm-14.qa.lab.tlv.redhat.com
> --otopi-environment="OSETUP_RENAME/forceIgnoreAIAInCA=bool:'True'
> OVESETUP_CORE/engineStop=bool:'True'
> OSETUP_RENAME/confirmForceOverwrite=bool:'False'"

RHVM Upgrade Guide doesn't mention to use '--otopi-environment' options, see https://access.redhat.com/documentation/en/red-hat-virtualization/4.0/paged/upgrade-guide/32-upgrading-to-red-hat-virtualization-manager-40 Thus maybe it is not necessary.

I looked at the machine on which you ran this, and I see in ovirt-engine-rename-20160920150315-j1klg5.log:

2016-09-20 15:03:15 DEBUG otopi.context context.dumpEnvironment:770 ENV OSETUP_RENAME/fqdn=str:''

This appears at a very early stage, before any interaction.

Any chance you ran there something like:

/usr/share/ovirt-engine/setup/bin/ovirt-engine-rename --newname=

?

That is, with an empty newname?

The sequence of events I see there is:

1. Several runs of engine-setup, all successful and ok
2. Above run of ovirt-engine-rename to an empty fqdn, also finished successfully and set fqdn to be the empty string (can be seen also in /etc/ovirt-engine/engine.conf.d/10-setup-protocols.conf.20160920165447 )
3. Several runs of setup and rename, all failing with a similar error message.
4. Two successful runs of rename, probably done after manually changing /etc/ovirt-engine-setup.conf.d/20-setup-ovirt-post.conf .
5. I now manually ran there '/usr/share/ovirt-engine/setup/bin/ovirt-engine-rename --newname=' and it succeeded too.

So current bug is something like:

Running setup or rename after renaming the engine to '' fails

A different bug you might consider is:

rename allows setting an empty new name using the command line option --newname= .

I'd not consider any of them severe. Both probably affect at least 3.6, perhaps even 3.3, didn't check, and this is the first report I received about them.

Tareq: Any idea what exact command you used for this log (created at 2016-09-20-15:03:15)?

I am not sure what i ran that time. 
But what i know is that i also ran ./ovirt-engine-rename --newname=jenkins-vm-14.qa.lab.tlv.redhat.com --otopi-environment="OSETUP_RENAME/forceIgnoreAIAInCA=bool:'True' OVESETUP_CORE/engineStop=bool:'True' OSETUP_RENAME/confirmForceOverwrite=bool:'False' OVESETUP_CONFIG/fqdn=str:jenkins-vm-14.qa.lab.tlv.redhat.com"

because it was complaining about missing fqdn.

(In reply to Tareq Alayan from comment #4)
> I am not sure what i ran that time. 

OK

> But what i know is that i also ran ./ovirt-engine-rename
> --newname=jenkins-vm-14.qa.lab.tlv.redhat.com
> --otopi-environment="OSETUP_RENAME/forceIgnoreAIAInCA=bool:'True'
> OVESETUP_CORE/engineStop=bool:'True'
> OSETUP_RENAME/confirmForceOverwrite=bool:'False'
> OVESETUP_CONFIG/fqdn=str:jenkins-vm-14.qa.lab.tlv.redhat.com"
> 
> because it was complaining about missing fqdn.

Indeed, as explained in comment 3.

Do we want to have a different bz for 'rename allows setting an empty new name using the command line option --newname='? Might be a little more important than current. Once we fix that one, current is really not important.

https://bugzilla.redhat.com/show_bug.cgi?id=1378352

Changing summary following comment 3. Still didn't check what component will need to be fixed, might be both setup and rename.

*** Bug 1493971 has been marked as a duplicate of this bug. ***

Closing old bugs.
Please reopen if still relevant.
Patches are welcomed.