Bug 1377828

Summary: Image upload: trying to upload image (any image) results in Error while executing action: General command validation failure
Product: [oVirt] ovirt-engine Reporter: Natalie Gavrielov <ngavrilo>
Component: BLL.StorageAssignee: Amit Aviram <aaviram>
Status: CLOSED CURRENTRELEASE QA Contact: Natalie Gavrielov <ngavrilo>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.0.4.4CC: bugs, gklein, kgoldbla, tnisan
Target Milestone: ovirt-4.0.5Flags: ngavrilo: needinfo-
tnisan: ovirt-4.0.z?
ngavrilo: planning_ack?
tnisan: devel_ack+
rule-engine: testing_ack+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-24 09:40:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
logs: engine.log, image-proxy.log, vdsm.log, snapshot
none
engine, server, vdsm none

Description Natalie Gavrielov 2016-09-20 17:41:21 UTC
Created attachment 1202987 [details]
logs: engine.log, image-proxy.log, vdsm.log, snapshot

Description of problem:
When trying to upload an image (any type: qcow2 / raw) to any type of storage domain (block / file) there is an error:
Error while executing action: General command validation failure.

and the following error in the engine.log:
Error during ValidateFailure.: java.lang.NullPointerException

Version-Release number of selected component:
rhevm-4.0.4.3-0.1.el7ev.noarch
ovirt-imageio-proxy-0.4.0-0.el7ev.noarch
ovirt-imageio-common-0.3.0-0.el7ev.noarch
vdsm-4.18.13-1.el7ev.x86_64
ovirt-imageio-daemon-0.4.0-0.el7ev.noarch

How reproducible:
On my engine 100%

Steps to Reproduce:
Not sure what had changed - just upload an image the usual way.

Actual results:
UI Error: Operation cancelled, Error while executing action: General command validation failure

engine.log:
2016-09-20 20:07:28,546 WARN  [org.ovirt.engine.core.bll.storage.disk.image.UploadDiskImageCommand] (default task-10) [] Validation of action 'UploadDiskImage' failed for user admin@internal-authz. Reasons: VAR__ACTION__ADD,VAR__TYPE__DISK,CAN_DO_ACTION_GENERAL_FAILURE
2016-09-20 20:12:50,453 ERROR [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-16) [] Error during ValidateFailure.: java.lang.NullPointerException

Expected results:
For the upload to work (like it usually does).

Additional info:
* ovirt-imageio-proxy is up
* ovirt-imageio-daemon is up
* creation of a new disk is possible
* hosts are available
* browser has the certificate (configured properly)

Comment 1 Natalie Gavrielov 2016-09-20 18:26:30 UTC
Also tried:
* reboot one of the hosts
* attach a new storage domain

Comment 2 Amit Aviram 2016-09-26 10:55:29 UTC
The patch for this bug was merged to 4.0.4.4, and exists in the build. moving to ON_QA.

Comment 3 Gil Klein 2016-09-29 09:02:02 UTC
While 4.0.4 is already out, and this BZ was moved to QA very late, it will be verified as part of 4.0.5

Comment 4 Kevin Alon Goldblatt 2016-10-25 13:13:04 UTC
Tested with the following code:rhevm-4.0.5-0.1.el7ev.noarch
----------------------------------------
rhevm-4.0.5-0.1.el7ev.noarch
vdsm-4.18.13-1.el7ev.x86_64

Tested with the following scenario:

Steps to Reproduce:
1. WebAdmin -> Disks -> Upload -> Select image from its location and start the upload >>>>> After a minute or so the following error is displayed and the image upload fails:  Unable to upload image to disk f2ac4edd-cf49-4c63-84ee-31a1a71c8999 due to a network error. Make sure ovirt-imageio-proxy service is installed and configured, and ovirt-engine's certificate is registered as a valid CA in the browser.

ovirt-imageio-proxy is up and running on the engine
ovirt-imageio-proxy-0.4.0-0.el7ev.noarch

ovirt-imageio-daemon is up and running on the host
ovirt-imageio-daemon-0.3.0-0.el7ev.noarch 

Actual results:
After a minute or so the following error is displayed and the image upload fails


Expected results:


Moving to ASSIGNED!

Comment 5 Red Hat Bugzilla Rules Engine 2016-10-25 13:13:11 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Kevin Alon Goldblatt 2016-10-25 13:15:55 UTC
Created attachment 1213901 [details]
engine, server, vdsm

Added logs

Comment 7 Amit Aviram 2016-10-26 12:14:58 UTC
(In reply to Kevin Alon Goldblatt from comment #4)
> Tested with the following code:rhevm-4.0.5-0.1.el7ev.noarch
> ----------------------------------------
> rhevm-4.0.5-0.1.el7ev.noarch
> vdsm-4.18.13-1.el7ev.x86_64
> 
> Tested with the following scenario:
> 
> Steps to Reproduce:
> 1. WebAdmin -> Disks -> Upload -> Select image from its location and start
> the upload >>>>> After a minute or so the following error is displayed and
> the image upload fails:  Unable to upload image to disk
> f2ac4edd-cf49-4c63-84ee-31a1a71c8999 due to a network error. Make sure
> ovirt-imageio-proxy service is installed and configured, and ovirt-engine's
> certificate is registered as a valid CA in the browser.

This is not the described bug, you didn't have the "General command validation failure" message, and the upload has started. Please mark it as "Verified" and open a new bug for the problem you are describing here.

> 
> ovirt-imageio-proxy is up and running on the engine
> ovirt-imageio-proxy-0.4.0-0.el7ev.noarch
> 
> ovirt-imageio-daemon is up and running on the host
> ovirt-imageio-daemon-0.3.0-0.el7ev.noarch 
> 
> Actual results:
> After a minute or so the following error is displayed and the image upload
> fails
> 
> 
> Expected results:
> 
> 
> Moving to ASSIGNED!

Comment 8 Natalie Gavrielov 2016-10-31 14:38:13 UTC
Scenario: Upload an image (tested both RAW and qcow)

Verified, using the following builds (RHEV 4.0.5-5):
rhevm-4.0.5.4-0.1.el7ev.noarch
ovirt-imageio-proxy-0.4.0-0.el7ev.noarch
ovirt-imageio-daemon-0.4.0-0.el7ev.noarch
vdsm-4.18.15.2-1.el7ev.x86_64

Did not encounter any other issues.

Comment 9 Allon Mureinik 2016-11-24 09:40:09 UTC
4.0.5 has been released, closing.