Bug 1377847

Summary:	strace: Mode not shown for O_TMPFILE
Product:	Red Hat Enterprise Linux 7	Reporter:	Florian Weimer <fweimer>
Component:	strace	Assignee:	DJ Delorie <dj>
Status:	CLOSED ERRATA	QA Contact:	Michal Kolar <mkolar>
Severity:	medium	Docs Contact:	Vladimír Slávik <vslavik>
Priority:	medium
Version:	7.3	CC:	bgollahe, dj, fweimer, hannsj_uhl, jfeeney, law, mcermak, mkolar, mnewsome, prarit, vslavik, yselkowi
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	strace-4.12-3.el7	Doc Type:	Bug Fix
Doc Text:	strace displays correctly the `O_TMPFILE` flag and mode for `open()` function Previously, the strace utility did not recognize existence of the `O_TMPFILE` flag for the system function `open()` and its requirement for presence of mode option. As a consequence, the strace output did not show name of the respective flag and lacked the mode option value. The strace utility has been extended to recognize this situation. As a result, the `O_TMPFILE` flag and mode are displayed correctly.	Story Points:	---
Clone Of:	1377846	Environment:
Last Closed:	2017-08-01 22:03:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1377846, 1436879
Bug Blocks:	1381083, 1390370

Description Florian Weimer 2016-09-20 18:29:04 UTC

+++ This bug was initially created as a clone of Bug #1377846 +++

I get this:

open("/tmp", O_RDWR|O_EXCL|O_DIRECTORY|O_TMPFILE) = 3
openat(AT_FDCWD, "/tmp", O_RDWR|O_EXCL|O_DIRECTORY|O_TMPFILE) = 3

O_TMPFILE reqires the mode argument (just like O_CREAT), so strace should show it as well.

Seen with strace-4.13-1.fc24.x86_64.

Comment 6 Michal Kolar 2017-03-23 14:00:34 UTC

Seems not resolved. O_TMPFILE flag is not declared on RHEL7.4 and __O_TMPFILE flag does not work correctly.



RHEL 7.4:
  strace-4.12-1.el7 kernel-3.10.0-595.el7 kernel-4.5.0-15.2.1.el7.aarch64

  O_TMPFILE flag undeclared; strace log for __O_TMPFILE flag:
    open("/tmp", O_WRONLY|O_DIRECTORY|0x400000) = -1 EISDIR (Is a directory)
    openat(AT_FDCWD, "/tmp", O_WRONLY|O_DIRECTORY|0x400000) = 3



RHEL 7.4 with Pegas kernel:
  4.5.0-15.2.1.el7.aarch64 --> kernel-4.10.0-4.el7.aarch64
  3.10.0-595.el7 --> kernel-4.10.0-4.el7 (ppc64le;x86_64;s390x)

  strace log for __O_TMPFILE flag:
    open("/tmp", O_WRONLY|O_DIRECTORY|0x400000) = 3
    openat(AT_FDCWD, "/tmp", O_WRONLY|O_DIRECTORY|0x400000) = 3



Fedora 25:
  strace-4.14-1.fc25.armv7hl kernel-4.8.6-300.fc25.armv7hl
  strace-4.16-1.fc25 kernel-4.9.14-200.fc25 (i386;x86_64;ppc64;ppc64le;aarch64)

  O_TMPFILE flag declared; strace log:
    open("/tmp", O_WRONLY|O_DIRECTORY|O_TMPFILE, 0700) = 3
    openat(AT_FDCWD, "/tmp", O_WRONLY|O_DIRECTORY|O_TMPFILE, 0700) = 3


Please review. Thanks

Comment 14 Michal Kolar 2017-04-18 11:27:19 UTC

Reproduced against strace-4.8-11.el7 and verified against strace-4.12-3.el7 with kernel-3.10.0-637.el7, kernel-4.5.0-15.2.1.el7.aarch64.

Comment 21 errata-xmlrpc 2017-08-01 22:03:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:2018