Bug 1377928
| Summary: | Inclusion of "s" to denote seconds in power_timeout attribute causes fence_ipmilan STONITH devices to fail. | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Simon Thomson <simmotommo> | |
| Component: | fence-agents | Assignee: | Marek Grac <mgrac> | |
| Status: | CLOSED ERRATA | QA Contact: | cluster-qe <cluster-qe> | |
| Severity: | urgent | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 7.2 | CC: | cluster-maint, jpokorny, mjuricek, oalbrigt | |
| Target Milestone: | rc | |||
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | fence-agents-4.0.11-52.el7 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1377970 (view as bug list) | Environment: | ||
| Last Closed: | 2017-08-01 16:10:32 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1377970 | |||
|
Description
Simon Thomson
2016-09-21 04:02:45 UTC
Hi, I agree that there should be no python exception visible for users and we will fix that. But suffixes like '[smh]' are not used in cluster suite, so we will not support this. Appropriate error message should be displayed. Hi Marek, An informative error message or just accepting and discarding suffixes like '[smh]' if they are configured would be useful. Thanks. There seems to be some inconsistency around the requirement/acceptance of these suffixes for time based cluster suite parameters. In this case using a suffix causes a failure. In others we are directed to use a suffix in Red Hat High Availability Documentation. e.g. From https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/High_Availability_Add-On_Reference/s1-fencedevicecreate-HAAR.html "The following command creates a stonith device. # pcs stonith create MyStonith fence_virt pcmk_host_list=f1 op monitor interval=30s" e.g. From https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/High_Availability_Add-On_Reference/s1-resourceopts-HAAR.html "In the following example, there is an existing resource named dummy_resource. This command sets the failure-timeout meta option to 20 seconds, so that the resource can attempt to restart on the same node in 20 seconds. # pcs resource meta dummy_resource failure-timeout=20s" If all time based cluster suite parameters can only be configured in seconds then a universal approach to accepting/rejecting/discarding suffixes like '[smh]' would make sense. I understand your concerns and they make sense, even more with the quotation from the documentation. Those 'interval=30s' are pacemaker/pcs that are not used in fence agent at all. So this transformation from [smh] to seconds should be done in pcs. I will add type 'seconds' so they know which options should be translated. Afterwards, [smh] should work as expected. Types (second/integer) were added to upstream. https://github.com/ClusterLabs/fence-agents/commit/e0fa4827b2ec931a182a3781cc2223c79cba2563 Looks good, thanks Marek. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:1874 |