Bug 1378014

Summary:	Review Request: perl-IO-FDPass - Pass a file descriptor over a socket
Product:	[Fedora] Fedora	Reporter:	Paul Howarth <paul>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-03 03:50:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1378028

Description Paul Howarth 2016-09-21 10:23:51 UTC

Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-IO-FDPass/branches/fedora/perl-IO-FDPass.spec

SRPM URL: http://www.city-fan.org/~paul/extras/perl-IO-FDPass/perl-IO-FDPass-1.1-2.fc26.src.rpm

Description:
This small low-level module only has one purpose: pass a file descriptor to
another process, using a (streaming) unix domain socket (on POSIX systems) or
any (streaming) socket (on WIN32 systems). The ability to pass file descriptors
on Windows is currently the unique selling point of this module. Have I
mentioned that it is really small, too?

Fedora Account System Username: pghmcfc

Comment 1 Petr Pisar 2016-09-22 12:30:52 UTC

URL and Source0 addresses are usable. Ok.
Source archive is original (SHA-256: ff3642dfd8e9cf2b4196c273cffbb2ccd5b55287e671ec6dd6083e8084546b10). Ok.
Summary verified from FDPass.pm. Ok.
Description verified from FDPass.pm. Ok.
License verified from COPYING. Ok.

TODO: I believe the `coreutils' build-time dependency is not needed as the spec file does not call "make dist".

TODO: Close standard input to the "perl Makefile.PL" command in order not to wait for interactive confirmation.

All tests pass. Ok.

$ rpmlint perl-IO-FDPass.spec ../SRPMS/perl-IO-FDPass-1.1-2.fc26.src.rpm ../RPMS/x86_64/perl-IO-FDPass-*
perl-IO-FDPass.src: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni
perl-IO-FDPass.x86_64: W: spelling-error %description -l en_US unix -> UNIX, Unix, uni
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
TODO: Upper-case the "unix" word in the description text.

$ rpm -q -lv -p ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm
drwxr-xr-x    2 root    root                        0 Sep 22 14:22 /usr/lib64/perl5/vendor_perl/IO
-rw-r--r--    1 root    root                     4486 Jul  6  2015 /usr/lib64/perl5/vendor_perl/IO/FDPass.pm
drwxr-xr-x    2 root    root                        0 Sep 22 14:22 /usr/lib64/perl5/vendor_perl/auto/IO
drwxr-xr-x    2 root    root                        0 Sep 22 14:22 /usr/lib64/perl5/vendor_perl/auto/IO/FDPass
-rwxr-xr-x    1 root    root                    11240 Sep 22 14:22 /usr/lib64/perl5/vendor_perl/auto/IO/FDPass/FDPass.so
drwxr-xr-x    2 root    root                        0 Sep 22 14:22 /usr/share/doc/perl-IO-FDPass
-rw-r--r--    1 root    root                      806 Jul  6  2015 /usr/share/doc/perl-IO-FDPass/Changes
-rw-r--r--    1 root    root                     4630 Jul  6  2015 /usr/share/doc/perl-IO-FDPass/README
drwxr-xr-x    2 root    root                        0 Sep 22 14:22 /usr/share/licenses/perl-IO-FDPass
-rw-r--r--    1 root    root                       62 Mar 29  2013 /usr/share/licenses/perl-IO-FDPass/COPYING
-rw-r--r--    1 root    root                     3068 Sep 22 14:22 /usr/share/man/man3/IO::FDPass.3pm.gz
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm | sort -f | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.24()(64bit)
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(XSLoader)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm | sort -f | uniq -c
      1 perl(IO::FDPass) = 1.1
      1 perl-IO-FDPass = 1.1-2.fc26
      1 perl-IO-FDPass(x86-64) = 1.1-2.fc26
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/x86_64/perl-IO-FDPass-1.1-2.fc26.x86_64.rpm 
Binary dependencies resolvable. Ok.

Package builds in F26 (http://koji.fedoraproject.org/koji/taskinfo?taskID=15750001). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Please consider fixing `TODO' items before building this package.
Resolution: Package APPROVED.

Comment 2 Paul Howarth 2016-09-22 13:13:50 UTC

(In reply to Petr Pisar from comment #1)
> TODO: I believe the `coreutils' build-time dependency is not needed as the
> spec file does not call "make dist".

It's needed for %{_fixperms} though.

> TODO: Close standard input to the "perl Makefile.PL" command in order not to
> wait for interactive confirmation.

I'll avoid the interactive prompt by setting PERL_CANARY_STABILITY_NOPROMPT=1

> $ rpmlint perl-IO-FDPass.spec ../SRPMS/perl-IO-FDPass-1.1-2.fc26.src.rpm
> ../RPMS/x86_64/perl-IO-FDPass-*
> perl-IO-FDPass.src: W: spelling-error %description -l en_US unix -> UNIX,
> Unix, uni
> perl-IO-FDPass.x86_64: W: spelling-error %description -l en_US unix -> UNIX,
> Unix, uni
> 3 packages and 1 specfiles checked; 0 errors, 2 warnings.
> TODO: Upper-case the "unix" word in the description text.

Will do.

> Resolution: Package APPROVED.

Thanks for the review Petr.

Comment 3 Petr Pisar 2016-09-22 13:26:11 UTC

(In reply to Paul Howarth from comment #2)
> (In reply to Petr Pisar from comment #1)
> > TODO: I believe the `coreutils' build-time dependency is not needed as the
> > spec file does not call "make dist".
> 
> It's needed for %{_fixperms} though.
> 
I think it's responsibility of the package that defines the macro (rpm-build?).

Comment 4 Paul Howarth 2016-09-22 13:34:25 UTC

(In reply to Petr Pisar from comment #3)
> (In reply to Paul Howarth from comment #2)
> > (In reply to Petr Pisar from comment #1)
> > > TODO: I believe the `coreutils' build-time dependency is not needed as the
> > > spec file does not call "make dist".
> > 
> > It's needed for %{_fixperms} though.
> > 
> I think it's responsibility of the package that defines the macro
> (rpm-build?).

There are probably a lot of macros defined there, some possibly for quite esoteric situations. I think at best it would warrant a Recommends: or even a Suggests: there for things it refers to in macro definitions.

To be honest I don't see coreutils ever disappearing from the minimal buildroot but I'd rather not make it a special case, and specify a buildreq for everything I explicitly use in a spec file.

Comment 5 Gwyn Ciesla 2016-09-22 14:02:10 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-IO-FDPass

Comment 6 Fedora Update System 2016-09-23 23:47:01 UTC

perl-IO-FDPass-1.1-3.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0ce15e8fa9

Comment 7 Fedora Update System 2016-09-24 00:53:42 UTC

perl-IO-FDPass-1.1-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-76dc50a7d2

Comment 8 Fedora Update System 2016-09-24 00:54:08 UTC

perl-IO-FDPass-1.1-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-521b8ec92d

Comment 9 Fedora Update System 2016-09-24 01:51:48 UTC

perl-IO-FDPass-1.1-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e0de107952

Comment 10 Fedora Update System 2016-09-26 22:49:35 UTC

perl-IO-FDPass-1.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4b7393cfce

Comment 11 Fedora Update System 2016-10-03 03:50:20 UTC

perl-IO-FDPass-1.1-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2016-10-03 06:20:24 UTC

perl-IO-FDPass-1.1-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-10-09 02:53:23 UTC

perl-IO-FDPass-1.1-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2016-10-10 02:17:37 UTC

perl-IO-FDPass-1.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2016-10-11 17:21:14 UTC

perl-IO-FDPass-1.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.