Bug 1378017

Summary: rpm -V ixpdimm_sw package fails after installing ixpdimm-monitor
Product: Red Hat Enterprise Linux 7 Reporter: Zhang Yi <yizhan>
Component: ixpdimm_swAssignee: Jeff Moyer <jmoyer>
Status: CLOSED WONTFIX QA Contact: Zhang Yi <yizhan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.3CC: juston.li
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-09 20:01:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Zhang Yi 2016-09-21 10:31:56 UTC 
Description of problem:
rpm -V of the ixpdimm_sw package fails after installing ixpdimm-monitor

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. install ixpdimm_sw and Verify with `rpm -V`
#rpm -ivh ixpdimm_sw-01.00.00.2111-1.el7.x86_64.rpm
#rpm -V ixpdimm_sw-01.00.00.2111-1.el7.x86_64
#echo $?
#0
2. install libixpdimm-core/libixpdimm-cim/ixpdimm-monitor
#rpm -ivh libixpdimm-core-01.00.00.2111-1.el7.x86_64.rpm libixpdimm-cim-01.00.00.2111-1.el7.x86_64.rpm ixpdimm-monitor-01.00.00.2111-1.el7.x86_64.rpm 
#rpm -V ixpdimm_sw-01.00.00.2111-1.el7.x86_64
..5....T.  c /var/lib/ixpdimm_sw/apss.dat

Actual results:


Expected results:


Additional info:
Comment 2 Jeff Moyer 2016-09-21 13:11:01 UTC 
That file should not be owned by any package.  We also need to stop the ixpdimm-monitor %post from starting the service.
Comment 3 Jeff Moyer 2017-10-20 20:41:56 UTC 
Hi, Juston,

Can you modify ixpdimm-monitor to just create this database file if it doesn't exist instead of failing to start?  Then we can nuke the database file from the files list for the package.
Comment 4 Jeff Moyer 2017-10-20 20:47:59 UTC 
If that really is a config file that users modify, we could do something like:

%verify(not md5 size mtime) %config(noreplace) /var/lib/ixpdimm_sw/apss.dat

Juston, what do you think?
Comment 5 Juston Li 2017-10-20 22:22:15 UTC 
(In reply to Jeff Moyer from comment #3)
> Hi, Juston,
> 
> Can you modify ixpdimm-monitor to just create this database file if it
> doesn't exist instead of failing to start?  Then we can nuke the database
> file from the files list for the package.

Someone suggested this before, we'll look into it, it makes sense to me.

(In reply to Jeff Moyer from comment #4)
> If that really is a config file that users modify, we could do something
> like:
> 
> %verify(not md5 size mtime) %config(noreplace) /var/lib/ixpdimm_sw/apss.dat
> 
> Juston, what do you think?

Correct me if I'm wrong but adding that line will prevent an overwrite on an upgrade?

So it does store some user preferences there. The problem is it also stores data we may change in new versions...

We'll look into a fix for this. Thanks!
Comment 6 Juston Li 2017-10-20 22:31:35 UTC 
(In reply to Jeff Moyer from comment #2)
> That file should not be owned by any package.  We also need to stop the
> ixpdimm-monitor %post from starting the service.

Is this still applicable? Should we not be starting the service?
Comment 7 Jeff Moyer 2017-10-20 22:51:14 UTC 
Yes, that's still applicable.  See:
  https://fedoraproject.org/wiki/Packaging:Systemd#Why_don.27t_we....

Where it states:
 Why don't we....

    Start the service after installation? 

Installations can be in changeroots, in an installer context, or in other situations where you don't want the services autostarted.

Thanks!
Comment 8 Jeff Moyer 2018-04-09 20:01:10 UTC 
This package is deprecated.  If customers wish to use this software, they will have to get it from Intel directly.