Bug 1378161

Summary: Workers are still spawned even with 0 packages
Product: [Fedora] Fedora Reporter: Michael V. Pelletier <mvpel>
Component: createrepoAssignee: Packaging Maintenance Team <packaging-team-maint>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 26CC: lewk, packaging-team-maint
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-05-29 11:34:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Michael V. Pelletier 2016-09-21 16:28:06 UTC
Description of problem:
On CentOS 7.2 the default behavior of createrepo is apparently to start as many workers as there are processor cores on the system. We have a system with 96 cores, and running createrepo on a directory containing only a handful of rpm files still creates all 96 workers with most of them reporting "0 pkgs."

Version-Release number of selected component (if applicable):
createrepo-0.9.9-25.el7_2.noarch
CentOS 7.2 with kernel 3.10.0-327.13.1.el7.x86_64
Python 2.7.5-39.el7_2

How reproducible:
Every time.


Steps to Reproduce:
1. Create a directory containing one RPM on a multi-core system.
2. Run createrepo on the directory.
3. Observe the "Spawning worker X with 0 pkgs" messages

Actual results:
Spawning worker 92 with 0 pkgs
Spawning worker 93 with 0 pkgs
Spawning worker 94 with 0 pkgs
Spawning worker 95 with 0 pkgs
...etc...

Expected results:
Workers with zero packages should not be spawned.

Additional info:

Comment 1 Michael V. Pelletier 2016-09-21 16:57:52 UTC
Patch:

--- __init__.py.orig    2016-02-16 11:07:30.000000000 -0500
+++ __init__.py 2016-09-21 12:55:46.267605489 -0400
@@ -632,6 +632,8 @@
             self._worker_tmp_path = tempfile.mkdtemp() # setting this in the base object so we can clean it up later
             if self.conf.workers < 1:
                 self.conf.workers = num_cpus_online()
+            if self.conf.workers > len(pkgfiles):
+                self.conf.workers = len(pkgfiles)
             pkgfiles.sort()
             worker_chunks = split_list_into_equal_chunks(pkgfiles, self.conf.workers)
             worker_cmd_dict = {}

Comment 2 Fedora End Of Life 2017-02-28 10:20:40 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 26 development cycle.
Changing version to '26'.

Comment 3 Fedora End Of Life 2018-05-03 09:06:20 UTC
This message is a reminder that Fedora 26 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 26. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '26'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 26 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 4 Fedora End Of Life 2018-05-29 11:34:38 UTC
Fedora 26 changed to end-of-life (EOL) status on 2018-05-29. Fedora 26
is no longer maintained, which means that it will not receive any
further security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.