Bug 1378215
| Summary: | deploy_hook() traceback on missing mandatory arguments | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Alois Mahdal <amahdal> |
| Component: | preupgrade-assistant | Assignee: | Petr Hracek <phracek> |
| Status: | CLOSED ERRATA | QA Contact: | Alois Mahdal <amahdal> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.7 | CC: | fkluknav, jmazanek, phracek, pstodulk |
| Target Milestone: | rc | Keywords: | Extras, Patch |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | preupgrade-assistant-2.1.10-3.el6 | Doc Type: | No Doc Update |
| Doc Text: |
undefined
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-04 08:59:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Tested with preupgrade-assistant-2.1.10-5.el6. All deploy_hook() (Bash and Python) cases now pass. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-2616.html |
Description of problem ====================== If an upgrade path module calls preupg.script_api.deploy_hook() but fails to provide mandatory arguments, the module will raise uncaught IndexError exception. This is due to incorrect parsing of arguments (`if arg[0] == "":`...) Version-Release number of selected component ============================================ preupgrade-assistant-2.1.10-1.el6 How reproducible ================ Always Steps to Reproduce ================== 1. Have a Python upgrade path module call deploy_hook() without one or both mandatory arguments 2. Observe HTML report or XML node Actual results ============== Traceback Expected results ================ Useful error is logged Additional info =============== Upstream PR is ready: https://github.com/upgrades-migrations/preupgrade-assistant/pull/150