Bug 1378454

Summary:	[GSS](6.4.z) The outcome of xa_commit call on non exiting transaction is silently ignored
Product:	[JBoss] JBoss Enterprise Application Platform 6	Reporter:	Tom Ross <tom.ross>
Component:	EJB, Transaction Manager	Assignee:	Fedor Gavrilov <fgavrilo>
Status:	CLOSED WONTFIX	QA Contact:	Jiří Bílek <jbilek>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	6.4.9	CC:	bmaxwell, david.lloyd, fgavrilo, jbilek, jboss-set, jmartisk, jolee, lakagwu, msochure, ochaloup, pjurak, rnetuka, sappleto, sfikes, tom.jenkinson
Target Milestone:	CR1
Target Release:	EAP 6.4.15
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1378396	Environment:
Last Closed:	2018-01-22 22:14:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1378396
Bug Blocks:

Description Tom Ross 2016-09-22 12:52:26 UTC

This from mail thread on transactional mailing list:
There is definitely a bug in EJBR.
 
These two at least look wrong by inspection:
https://github.com/wildfly/wildfly/blob/master/ejb3/src/main/java/org/jboss/as/ejb3/remote/protocol/versionone/XidTransactionPrepareTask.java#L100
https://github.com/wildfly/wildfly/blob/master/ejb3/src/main/java/org/jboss/as/ejb3/remote/protocol/versionone/XidTransactionCommitTask.java#L68
 
The way they are implemented means that when the transaction manager calls commit/prepare on an Xid if there is no transaction at the remote side EJBR just ignores the problem whereas it needs to return an XA error so the TM knows about it.
 
You could simulate this with a test case that gets hold of the EJBR XAResource and invokes:
xar.prepare(dummyXid) and does not get back XAER_NOTA
 
That explains how the root transaction can prepare/commit without error as we can see here:
 
2016-09-12 16:04:02,303 TRACE [com.arjuna.ats.jta] (EJB async - 8) XAResourceRecord.topLevelPrepare for XAResourceRecord < resource:ResourceImpl{transactionKey=0:ffff0af7f6b6:6b296e38:57d14447:63f2e, ejbClientContext=org.jboss.ejb.client.EJBClientContext@18d6826a, nodeName='svc-2-presentation', state=State{transactionID=org.jboss.ejb.client.XidTransactionID@303ce194, suspended=false, participantCnt=0}}, txid:< formatId=131077, gtrid_length=46, bqual_length=36, tx_uid=0:ffff0af7f6b6:6b296e38:57d14447:63f2e, node_name=svc_2_presentation, branch_uid=0:ffff0af7f6b6:6b296e38:57d14447:63f4a, subordinatenodename=null, eis_name=unknown eis name >, heuristic: TwoPhaseOutcome.FINISH_OK com.arjuna.ats.internal.jta.resources.arjunacore.XAResourceRecord@1754f10f >, record id=0:ffff0af7f6b6:6b296e38:57d14447:63f4b
 
2016-09-12 16:04:02,364 TRACE [com.arjuna.ats.jta] (EJB async - 8) XAResourceRecord.topLevelCommit for XAResourceRecord < resource:ResourceImpl{transactionKey=0:ffff0af7f6b6:6b296e38:57d14447:63f2e, ejbClientContext=org.jboss.ejb.client.EJBClientContext@18d6826a, nodeName='svc-2-presentation', state=null}, txid:< formatId=131077, gtrid_length=46, bqual_length=36, tx_uid=0:ffff0af7f6b6:6b296e38:57d14447:63f2e, node_name=svc_2_presentation, branch_uid=0:ffff0af7f6b6:6b296e38:57d14447:63f4a, subordinatenodename=null, eis_name=unknown eis name >, heuristic: TwoPhaseOutcome.FINISH_OK com.arjuna.ats.internal.jta.resources.arjunacore.XAResourceRecord@1754f10f >, record id=0:ffff0af7f6b6:6b296e38:57d14447:63f4b
 
Both those lines I indicated above have debug statements but they should be ERROR and return appropriate XA exceptions.
 
What it does not explain is why the transaction is initially imported 45 minutes later. I guess it is stuck in some EJB processing queue.

Comment 13 Jiří Bílek 2017-04-26 15:00:41 UTC

I used test from crashrec testsuite for reproducing the issue

mvn clean verify -Djboss.dist=$JBOSS_HOME -Dtest=TxPropagationEJbXAResourceTestCase -Deap6 -DfailIfNoTests=false

Non exiting transaction is still silently ignored -> Reopened.