| Summary: | cockpit-ovirt package includes twice patterfly related files | ||
|---|---|---|---|
| Product: | [oVirt] cockpit-ovirt | Reporter: | Sandro Bonazzola <sbonazzo> |
| Component: | Generic | Assignee: | Marek Libra <mlibra> |
| Status: | CLOSED WONTFIX | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | --- | CC: | bugs, tjelinek |
| Target Milestone: | --- | Flags: | rule-engine:
planning_ack?
rule-engine: devel_ack? rule-engine: testing_ack? |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-10-11 07:19:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Sandro Bonazzola
2016-09-22 13:19:44 UTC
I thnk it's better to stay on patternfly3 in the cockpit-ovirt, so it will be aligned with the rest of the Cockpit it lives in. The patternfly3 is provided by ovirt-engine-nodejs-modules, so shared among projects as well. The fonts, CSS, icons files are generated during the build process as a result of webpack analyzis what resources are really needed by the resulting bundle. I would not change that, that's a good feature. Regarding their duplicity in the cockpit-ovirt rpm: the 'dashboard' and 'vdsm' parts are more-or-less independent subpackages with their own webpack builds resulting in the partial duplicity of the generated resource files. Since there's ongoing activity to split the 'dashboard' even more and separate the 'vdsm' part to a new rpm, I would not change that as well. |