Bug 1378507

Summary: Custom automate dialog buttons in hosts results in cfme exception
Product: Red Hat CloudForms Management Engine Reporter: Matouš Mojžíš <mmojzis>
Component: UI - OPSAssignee: Brian McLaughlin <bmclaugh>
Status: CLOSED ERRATA QA Contact: Shveta <sshveta>
Severity: medium Docs Contact:
Priority: high    
Version: 5.6.0CC: bmclaugh, dclarizi, hkataria, jhardy, mpovolny, obarenbo, sboulden, simaishi
Target Milestone: GAKeywords: ZStream
Target Release: 5.7.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.7.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1393130 (view as bug list) Environment:
Last Closed: 2017-01-04 13:00:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1393130    
Attachments:
Description Flags
production.log none

Description Matouš Mojžíš 2016-09-22 15:15:25 UTC
Created attachment 1203795 [details]
production.log

Description of problem:


Version-Release number of selected component (if applicable):
5.6.2.0

How reproducible:
Always

Steps to Reproduce:
1. In automate->customization add dialog
2. In automate->customization->buttons add host button and pair it with that dialog
3. In compute->hosts->host select that button
4. Then select submit or cancel

Actual results:
Selecting submit or cancel results in this error:
undefined method `redirect_url' for #<#<Class:0x000000016b20f0>:0x00000015061890> [host/dialog_form_button_pressed] 
and production.log as attachment

Expected results:
No errors

Additional info:

Comment 4 CFME Bot 2016-11-04 13:36:22 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/5c553a3291fbb1f5570b3a7618b2695c61ca8d26

commit 5c553a3291fbb1f5570b3a7618b2695c61ca8d26
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Mon Oct 24 11:17:29 2016 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Mon Oct 24 11:17:29 2016 -0400

    Fix exception in custom automate dialog buttons in hosts
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1378507

 app/controllers/application_controller/dialog_runner.rb | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comment 5 CFME Bot 2016-11-04 13:36:27 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/2d1b401b43dd70b7916991235f64bf2f6cf03020

commit 2d1b401b43dd70b7916991235f64bf2f6cf03020
Author:     Brian McLaughlin <bmclaugh>
AuthorDate: Mon Oct 24 11:19:15 2016 -0400
Commit:     Brian McLaughlin <bmclaugh>
CommitDate: Mon Oct 24 11:19:15 2016 -0400

    Spec tests
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1378507

 .../application_controller/dialog_runner_spec.rb   | 40 +++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

Comment 10 Shveta 2016-11-11 04:46:41 UTC
Fixed.
verified in 5.7.0.10-beta3.20161109111947_9a61b18

Comment 12 errata-xmlrpc 2017-01-04 13:00:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0012.html

Comment 13 Martin Hradil 2017-05-11 10:33:20 UTC
*** Bug 1399027 has been marked as a duplicate of this bug. ***