Bug 1378518

Summary: Persistent names are not used for disk devices in fstab and zipl.conf on s390x
Product: [Fedora] Fedora Reporter: Jan Stodola <jstodola>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: high    
Version: 25CC: anaconda-maint-list, g.kaviyarasu, jonathan, mkolman, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: s390x   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-10-13 12:14:10 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765, 1378351    
Attachments:
Description Flags
storage.log
none
fstab
none
zipl.conf none

Description Jan Stodola 2016-09-22 15:43:40 UTC
Description of problem:
Device names written to /etc/fstab and /etc/zipl.conf during installation on s390x are not persistent:

fstab:

/dev/dasdc1             /                       xfs     defaults        0 0
/dev/dasda1             /boot                   ext4    defaults        1 2
/dev/dasdb1             swap                    swap    defaults        0 0


$ cat zipl.conf | grep root=
        parameters="root=/dev/dasdc1 cio_ignore=all,!condev rd.znet=qeth,0.0.0a00,0.0.0a01,0.0.0a02,layer2=1,portno=0,portname=FOOBAR LANG=en_US.UTF-8"
        parameters="root=/dev/dasdc1 cio_ignore=all,!condev rd.znet=qeth,0.0.0a00,0.0.0a01,0.0.0a02,layer2=1,portno=0,portname=FOOBAR"
$ 

Since the names of the devices can change each reboot, the system often doesn't boot.
Persistent names/UUIDs/LABELs should be used instead.

Version-Release number of selected component (if applicable):
anaconda-25.20.1-1.fc25
python3-blivet-2.1.2-1.fc25

How reproducible:
always on s390x

Steps to Reproduce:
1. proceed through text mode installation on s390x, use standard disk layout (without LVM/RAID)
2. before rebooting check /mnt/sysimage/etc/fstab and /mnt/sysimage/etc/zipl.conf

Actual results:
Names /dav/dasd* used

Expected results:
Persistent names used (or UUID/LABEL)

Additional info:
I cannot reproduce it on x86_64, where partitions are referenced using their UUIDs, for example:

[root@localhost ~]# grep /boot /etc/fstab 
UUID=e4fffa90-384e-4d3a-955b-162dfb8c139a /boot     ext4    defaults        1 2
[root@localhost ~]#

Comment 3 Jan Stodola 2016-09-22 15:45:43 UTC
Created attachment 1203822 [details]
storage.log

Comment 5 Jan Stodola 2016-09-22 15:47:47 UTC
Created attachment 1203827 [details]
fstab

Comment 6 Jan Stodola 2016-09-22 15:48:07 UTC
Created attachment 1203838 [details]
zipl.conf

Comment 7 Jan Stodola 2016-10-13 12:14:10 UTC
Retested on compose Fedora-25-20161007.0 with updates=http://fedora.danny.cz/s390/updates-1378338.img and I cannot reproduce it any longer:

[root@rtt7 ~]# cat /proc/cmdline 
root=/dev/disk/by-path/ccw-0.0.3027-part1 rd.dasd=0.0.3027 rd.dasd=0.0.3127 rd.dasd=0.0.3527 cio_ignore=all,!condev rd.znet=qeth,0.0.0a00,0.0.0a01,0.0.0a02,layer2=1,portno=0 LANG=en_US.UTF-8 BOOT_IMAGE=0
[root@rtt7 ~]# cat /etc/fstab 

#
# /etc/fstab
# Created by anaconda on Thu Oct 13 09:59:43 2016
#
# Accessible filesystems, by reference, are maintained under '/dev/disk'
# See man pages fstab(5), findfs(8), mount(8) and/or blkid(8) for more info
#
/dev/disk/by-path/ccw-0.0.3027-part1 /                       xfs     defaults        0 0
/dev/disk/by-path/ccw-0.0.3127-part1 /boot                   ext4    defaults        1 2
/dev/disk/by-path/ccw-0.0.3527-part1 swap                    swap    defaults        0 0
[root@rtt7 ~]#

So, I'm closing this bug for now.