Bug 1378605

https://review.gerrithub.io/353251

Kelab,

Can u please provide the steps to verify this bug.

Option 1.

1) fetch any RHGS-3.2 nfs-ganesha-gluster-2.4.1 package, e.g. from http://download-node-02.eng.bos.redhat.com/brewroot/packages/nfs-ganesha/2.4.1/9.el7rhgs/x86_64/

2) extract the contents with rpm2cpio, e.g. `rpm2cpio nfs-ganesha-gluster-2.4.1-9.el7rhgs.x86_64.rpm | cpio -id`

3) dump the symbols from the fsal shared lib, e.g. `nm -D usr/lib64/ganesha/libfsalgluster.so | grep inet_ntoa` and notice the reference to inet_ntoa().

4) repeat with  2.4.4, e.g. from http://download-node-02.eng.bos.redhat.com/brewroot/packages/nfs-ganesha/2.4.4/4.el7rhgs/x86_64/

5) extract the contents, e.g. `rpm2cpio nfs-ganesha-gluster-2.4.4-4.el7rhgs.x86_64.rpm | cpio -id`

6) dump the symbols, e.g. `nm -D usr/lib64/ganesha/libfsalgluster.so | grep inet_ntoa` and observe no reference to inet_ntoa().

Option 2.

The origin of this bug was an rpmdiff result that flagged the use of inet_ntoa() in rhgs-3.2, nfs-ganesha-2.4.1.

Examine the rpmdiff output from 3.2, nfs-ganesha-2.4.4 and observe no rpmdiff output

RHGS-3.3 https://errata.devel.redhat.com/rpmdiff/waivers_for_errata/27701

Kelab,


Verified both the options mentioned in the comment #9

Option 1 output is as expected mentioned in comment #9 in which there will be reference to inet_ntoa() in 2.4.1 nfs-ganesha-gluster package but no reference in 2.4.4 nfs-ganesha-gluster package

For option 2,  I  took the rpmdiff of 2.4.1 nfs-ganesha package and 2.4.4 nfs-ganesha package.But i am not able to figure it out what should be the expected diff.
According to rpmdiff,there is no diff related to the use of inet_ntoa() in 2.4.1


Attaching the output of option 2.
***************
Option 1:
****************

2.4.1
------
[root@dhcp42-117 3.2]# ls
nfs-ganesha-gluster-2.4.1-9.el7rhgs.x86_64.rpm
[root@dhcp42-117 3.2]# rpm2cpio nfs-ganesha-gluster-2.4.1-9.el7rhgs.x86_64.rpm | cpio -id
171 blocks
[root@dhcp42-117 3.2]# ls
etc  nfs-ganesha-gluster-2.4.1-9.el7rhgs.x86_64.rpm  usr
[root@dhcp42-117 3.2]# nm -D usr/lib64/ganesha/libfsalgluster.so | grep inet_ntoa
                 U inet_ntoa



2.4.4
------

# rpm2cpio nfs-ganesha-gluster-2.4.4-4.el7rhgs.x86_64.rpm | cpio -id
179 blocks
[root@dhcp42-117 3.3]# nm -D usr/lib64/ganesha/libfsalgluster.so | grep inet_ntoa


***************
Option 2:
****************


# rpmdiff nfs-ganesha-2.4.1-9.el7rhgs.x86_64.rpm nfs-ganesha-2.4.4-4.el7rhgs.x86_64.rpm
removed     REQUIRES config(nfs-ganesha) = 2.4.1-9.el7rhgs
removed     REQUIRES firewalld  
added       REQUIRES config(nfs-ganesha) = 2.4.4-4.el7rhgs
added       REQUIRES policycoreutils-python  
removed     PROVIDES config(nfs-ganesha) = 2.4.1-9.el7rhgs
removed     PROVIDES nfs-ganesha(x86-64) = 2.4.1-9.el7rhgs
added       PROVIDES config(nfs-ganesha) = 2.4.4-4.el7rhgs
added       PROVIDES nfs-ganesha(x86-64) = 2.4.4-4.el7rhgs
added       OBSOLETES nfs-ganesha-nullfs  
..........T /etc/dbus-1/system.d/org.ganesha.nfsd.conf
..........T /etc/ganesha
..........T /etc/ganesha/ganesha.conf
..........T /etc/logrotate.d/ganesha
..........T /etc/sysconfig/ganesha
S.5.......T /usr/bin/ganesha.nfsd
..........T /usr/lib/firewalld/services/nlm.xml
..........T /usr/lib/firewalld/services/rquota.xml
..........T /usr/lib/systemd/system/nfs-ganesha-config.service
..........T /usr/lib/systemd/system/nfs-ganesha-lock.service
..........T /usr/lib/systemd/system/nfs-ganesha.service
..........T /usr/libexec/ganesha
..........T /usr/libexec/ganesha/nfs-ganesha-config.sh
..........T /usr/share/doc/ganesha
..........T /usr/share/doc/ganesha/ChangeLog
..........T /usr/share/doc/ganesha/config_samples
..........T /usr/share/doc/ganesha/config_samples/README
..........T /usr/share/doc/ganesha/config_samples/ceph.conf
..........T /usr/share/doc/ganesha/config_samples/config.txt
removed     /usr/share/doc/ganesha/config_samples/config.txtb.1379673
..........T /usr/share/doc/ganesha/config_samples/ds.conf
..........T /usr/share/doc/ganesha/config_samples/export.txt
..........T /usr/share/doc/ganesha/config_samples/gluster.conf
..........T /usr/share/doc/ganesha/config_samples/gpfs.conf
..........T /usr/share/doc/ganesha/config_samples/gpfs.ganesha.exports.conf
..........T /usr/share/doc/ganesha/config_samples/gpfs.ganesha.log.conf
..........T /usr/share/doc/ganesha/config_samples/gpfs.ganesha.main.conf
..........T /usr/share/doc/ganesha/config_samples/gpfs.ganesha.nfsd.conf
..........T /usr/share/doc/ganesha/config_samples/logging.txt
..........T /usr/share/doc/ganesha/config_samples/logrotate_fsal_gluster
..........T /usr/share/doc/ganesha/config_samples/logrotate_ganesha
..........T /usr/share/doc/ganesha/config_samples/rgw.conf
..........T /usr/share/doc/ganesha/config_samples/vfs.conf
..........T /usr/share/doc/ganesha/config_samples/xfs.conf
..........T /usr/share/doc/ganesha/config_samples/zfs.conf
removed     /usr/share/licenses/nfs-ganesha-2.4.1
removed     /usr/share/licenses/nfs-ganesha-2.4.1/LICENSE.txt
added       /usr/share/licenses/nfs-ganesha-2.4.4
added       /usr/share/licenses/nfs-ganesha-2.4.4/LICENSE.txt
..........T /var/run/ganesha

Can you please look at the rpmdiff of option 2 mentioned in this comment ,and update is it the expected output?

For option 1 that is the expected output. There is no "U  inet_ntoa" line.

for option 2 I was not clear. The rpmdiff that I meant was the rpmdiff report in the errata, where there is no longer a report that inet_ntoa is used.

But option 1 output is sufficient, IMO, to confirm that inet_ntoa() is now not used.

Thanks kaleb for confirming.

Based on comment #10 and comment #11 ,moving this bug to verified state.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2017:2779