Bug 1378646

Summary: rpm contains extra files
Product: [Fedora] Fedora Reporter: Van de Bugger <van.de.bugger>
Component: geanyAssignee: Josef Bacik <josef>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 24CC: dmaphy, egolov, josef, oliver
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: geany-1.29-2.fc24 geany-1.29-2.fc25 geany-1.29-2.fc23 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-17 02:25:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Van de Bugger 2016-09-23 00:23:56 UTC
Description of problem:

Geany source package includes few template files. One such template is a template of Python program, file main.py. It is *not* an executable file, not a script, but just a template.

"make install" command installs this file (with other templates) into /usr/share/geany/templates/files/ directory.

However, when rpm package is built, this file is treated as a Python script, and two extra files are included into rpm: main.pyc and main.pyo (it seems rpmbuild does this). These files, main.pyc and main.pyo, should not be created and included into rpm package.

Version-Release number of selected component (if applicable):

Fedora 24 @ x86_64
geany-1.28-1.fc24

How reproducible:

Always

Steps to Reproduce:
1. dnf install geany
2. ls -1 /usr/share/geany/templates/files/*.py*

Actual results:

/usr/share/geany/templates/files/main.py
/usr/share/geany/templates/files/main.pyc
/usr/share/geany/templates/files/main.pyo

Expected results:

/usr/share/geany/templates/files/main.py

Additional info:

Comment 1 Van de Bugger 2016-09-23 23:15:27 UTC
It seems the problem cab be fixed by replacing

# The  Python templates in /usr/share/geany/templates can not be byte-compiled.
%global  _python_bytecompile_errors_terminate_build 0

with 

# The  Python templates in /usr/share/geany/templates should not be byte-compiled.
%undefine  py_auto_byte_compile

This completely disables compiling Python scripts, but it should be a problem because geany package does not include any Python scripts.

Comment 2 Fedora Update System 2016-11-14 10:30:31 UTC
geany-plugins-1.29-1.fc25 geany-1.29-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-01ad22d5c5

Comment 3 Fedora Update System 2016-11-14 10:31:02 UTC
geany-1.29-2.fc23 geany-plugins-1.29-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-24d2da2262

Comment 4 Fedora Update System 2016-11-14 10:31:22 UTC
geany-1.29-2.fc24 geany-plugins-1.29-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-81015859a4

Comment 5 Fedora Update System 2016-11-15 02:26:07 UTC
geany-1.29-2.fc23, geany-plugins-1.29-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-24d2da2262

Comment 6 Fedora Update System 2016-11-15 02:30:20 UTC
geany-1.29-2.fc24, geany-plugins-1.29-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-81015859a4

Comment 7 Fedora Update System 2016-11-15 13:27:09 UTC
geany-1.29-2.fc25, geany-plugins-1.29-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-01ad22d5c5

Comment 8 Fedora Update System 2016-11-17 02:25:26 UTC
geany-1.29-2.fc24, geany-plugins-1.29-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-11-21 18:53:54 UTC
geany-1.29-2.fc25, geany-plugins-1.29-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-11-25 07:22:31 UTC
geany-1.29-2.fc23, geany-plugins-1.29-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.