Bug 1378706

Summary: Need add missing flags to /etc/etcd/etcd.conf file in etcd3
Product: Red Hat Enterprise Linux 7 Reporter: Joy Pu <ypu>
Component: etcdAssignee: Jan Chaloupka <jchaloup>
Status: CLOSED ERRATA QA Contact: Martin Jenner <mjenner>
Severity: low Docs Contact:
Priority: low    
Version: 7.3CC: sdodson
Target Milestone: rcKeywords: Extras
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: etcd-3.2.15-1.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-03-07 09:50:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Joy Pu 2016-09-23 07:08:02 UTC
Description of problem:

The new flags in etcd3 is not added to the conf file. The flags are:
enable-pprof quota-backend-bytes auto-compaction-retention auto-tls


Version-Release number of selected component (if applicable):
etcd3-3.0.3-1.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Get etcd --help
$ etcd --help
2. Compare the flags with the flags we get from etcd.conf

Actual results:
Above flags are missing

Expected results:
All flags is added to conf file


Additional info:

Comment 2 Joy Pu 2016-09-27 06:31:59 UTC
Hi Jan

enable-pprof and quota-backend-bytes are still missing. Can you help to check it again?

Comment 3 Jan Chaloupka 2016-09-27 14:59:55 UTC
My assumption is the --enable-pprof is used for testing, not in production environment. Though, if it is not, I can append it to the config file as well.

Reading https://github.com/coreos/etcd/blob/master/Documentation/op-guide/configuration.md the --quota-backend-bytes option is not documented.

Comment 4 Joy Pu 2016-09-28 04:17:40 UTC
Hi Jan,

--enable-pprof maybe is a profile flag more than just for testing. It may help users or admins to get the status of etcd service. We can find it based on the commit log here: https://github.com/coreos/etcd/pull/4155/commits/588f655b4e7dbae5686d32a64895bf0b4137fbdd

The flag --quota-backend-bytes is not an experimental flag based on the discuss in this pullreq https://github.com/coreos/etcd/pull/5146 . So I think it not shows up in the doc maybe because they forget to but not because it should not be there.

By the way from the output of etcd --help in early stage of etcd3, we can find some flags under "experimental" category which means the flags are there just for testing. And now we still can see the "unsafe" category in the flags which means the flags need pay more attention when we use it. There is also some old flags need to be drop some day is marked as "DEPRECATED".  I skip these three types of flag in my check script. So It should be OK to put all rest of flags to the configure file.

Comment 5 Joy Pu 2017-01-10 11:13:03 UTC
Still get this problem for new version of etcd package, following flags are missing:

enable-pprof quota-backend-bytes auto-compaction-retention auto-tls

But as etcd3 package are not used any more should we update this bug to etcd?

Comment 6 Jan Chaloupka 2017-05-11 10:18:07 UTC
Let's keep this opened and close it once the etcd.conf is generated automatically or once there is at least verify.sh script, that will check if all flags are present on the etcd.conf file.

Comment 8 Joy Pu 2018-02-13 08:18:13 UTC
Test with new etcd and find one problem:
In the /etc/etcd/etcd.conf "auto-compaction-retention" is under version but it is under "clustering flags" in the help output.

Comment 9 Jan Chaloupka 2018-02-23 14:13:07 UTC
Please, open another bug for it.

Comment 10 Joy Pu 2018-02-24 02:54:32 UTC
As use another bug for this problem. Set this to verified.

Comment 13 errata-xmlrpc 2018-03-07 09:50:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0427