Bug 1378716

Summary: Invalid url can be saved by editing bc page
Product: OKD Reporter: Yanping Zhang <yanpzhan>
Component: Management ConsoleAssignee: Jakub Hadvig <jhadvig>
Status: CLOSED NOTABUG QA Contact: Yadan Pei <yapei>
Severity: low Docs Contact:
Priority: medium    
Version: 3.xCC: aos-bugs, mmccomas, spadgett, yapei
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-26 13:18:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
invalidurl.gif none

Description Yanping Zhang 2016-09-23 08:05:06 UTC 
Created attachment 1204027 [details]
invalidurl.gif

Description of problem:
When edit bc page, try to update "Source Repository URL" with an invalid url, click "Save" button, it saved successfully, and no errors show up.

Version-Release number of selected component (if applicable):
openshift v1.4.0-alpha.0+8134786-dirty
kubernetes v1.4.0-beta.3+d19513f
etcd 3.0.9

How reproducible:
Always

Steps to Reproduce:
1.Create app from template: https://raw.githubusercontent.com/openshift/origin/master/examples/sample-app/application-template-stibuild.json
2.Access bc edit page, update "Source Repository URL" from "https://github.com/openshift/ruby-hello-world.git" to "@%cccccc", then click "Save".

Actual results:
2.Could save successfully, and the Source repo in bc configuration page became "@%cccccc"

Expected results:
2.The "Save" button should be disabled when url is invalid, or should not save successfully and error info is needed.

Additional info:
Try to update the url in cli with "@%cccccc", could not update.
Comment 1 Samuel Padgett 2016-09-26 12:00:48 UTC 
Do you see a warning message? We don't disable the save button in this case on purpose, but you should see a warning.

We've had cases in the past where the regex was wrong, and we don't want to block submit. One example: https://github.com/openshift/origin/issues/2730
Comment 2 Samuel Padgett 2016-09-26 12:03:26 UTC 
This is the PR that relaxed validation for the "Add to Project" page:

https://github.com/openshift/origin/pull/2758
Comment 3 Jakub Hadvig 2016-09-26 13:18:07 UTC 
Closing this one after chat with Sam. Not a bug
Comment 4 Yanping Zhang 2016-09-27 09:02:17 UTC 
(In reply to Samuel Padgett from comment #1)
> Do you see a warning message? We don't disable the save button in this case
> on purpose, but you should see a warning.
> 
> We've had cases in the past where the regex was wrong, and we don't want to
> block submit. One example: https://github.com/openshift/origin/issues/2730

Do you mean this message "Git repository should be a URL."under the editor box when input "@%cccccc"? Could see it when the url string conatins "@".
But it inputs string "$$$$" or "#####", there is no this message and could save successfully. Is this also by design?
Comment 5 Samuel Padgett 2016-09-27 10:52:14 UTC 
Some of those are a problem, but we have another bug tracking that https://bugzilla.redhat.com/show_bug.cgi?id=1225420
Comment 6 Yanping Zhang 2016-09-27 11:03:12 UTC 
Samuel, Got it, thanks to confirm!