Bug 1378842

Summary: [RFE] 'gluster volume get' should implement the way to retrieve volume options using the volume name 'all'
Product: [Community] GlusterFS Reporter: Samikshan Bairagya <sbairagy>
Component: glusterdAssignee: Samikshan Bairagya <sbairagy>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: amukherj, bugs, sasundar
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.10.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1322212
: 1433751 (view as bug list) Environment:
Last Closed: 2017-03-06 17:27:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1322212    
Bug Blocks: 1433751    

Description Samikshan Bairagya 2016-09-23 11:02:36 UTC
+++ This bug was initially created as a clone of Bug #1322212 +++

Description of problem:
-----------------------
When setting the global options, 'gluster volume set' provides a way to set them using the volume name as 'all'

But 'gluster volume get' doesn't implement 'all' to get the global options.
So in order to get the global volume options one has to use 'gluster volume get' with specific volume name. This usage makes the illusion as though the option is set only on one volume, which is incorrect.

Retrieving the global volume options ( like op-version, etc ) using the volume name as 'all' should be implemented with 'gluster volume get' functionality


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
gluster 3.7.9 & mainline 

How reproducible:
-----------------
N/A as this is a Feature Request for 'gluster volume get' functionality

Steps to Reproduce:
-------------------
N/A as this is a Feature Request for 'gluster volume get' functionality

Actual results:
---------------
With current implementation, the global options are retrieved with 'gluster volume get' functionality using the specific volume name

Expected results:
-----------------
'gluster volume get' to implement the way to get the global options using - "gluster volume get all"

Comment 1 Worker Ant 2016-09-23 12:49:38 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#1) for review on master by Samikshan Bairagya (samikshan)

Comment 2 Worker Ant 2016-11-24 09:54:57 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#2) for review on master by Samikshan Bairagya (samikshan)

Comment 3 Worker Ant 2016-11-24 11:10:34 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#3) for review on master by Samikshan Bairagya (samikshan)

Comment 4 Worker Ant 2016-11-28 11:02:47 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#4) for review on master by Samikshan Bairagya (samikshan)

Comment 5 Worker Ant 2016-11-28 11:22:09 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#5) for review on master by Samikshan Bairagya (samikshan)

Comment 6 Worker Ant 2016-12-01 12:42:16 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#6) for review on master by Samikshan Bairagya (samikshan)

Comment 7 Worker Ant 2016-12-02 11:59:44 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#7) for review on master by Samikshan Bairagya (samikshan)

Comment 8 Worker Ant 2016-12-23 12:08:14 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#8) for review on master by Samikshan Bairagya (samikshan)

Comment 9 Worker Ant 2016-12-23 13:23:08 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#9) for review on master by Samikshan Bairagya (samikshan)

Comment 10 Worker Ant 2016-12-27 09:06:35 UTC
REVIEW: http://review.gluster.org/15563 (glusterd, cli: Get global options through volume get functionality) posted (#10) for review on master by Samikshan Bairagya (samikshan)

Comment 11 Worker Ant 2016-12-31 04:47:31 UTC
COMMIT: http://review.gluster.org/15563 committed in master by Atin Mukherjee (amukherj) 
------
commit 08056421b886b1ebf1e0eed93d9f6f9b6d017489
Author: Samikshan Bairagya <samikshan>
Date:   Fri Sep 23 16:35:15 2016 +0530

    glusterd, cli: Get global options through volume get functionality
    
    Currently it is not possible to retrieve values of global options
    by using the 'gluster volume get' functionality if there are no
    volumes present. In order to get the global options one has to use
    'gluster volume get' with a specific volume name. This usage makes
    the illusion as though the option is set only on one volume, which
    is incorrect. When setting the global options, 'gluster volume set'
    provides a way to set them using the volume name as 'all'.
    
    Similarly, retrieving the global options should be made possible by
    using the volume name 'all' with the 'gluster volume get'
    functionality. This patch adds that functionality to 'volume get'
    
    Usage:
    	# gluster volume get all <OPTION/all>
    
    Change-Id: Ic2fdb9eda69d4806d432dae26d117d9660fe6d4e
    BUG: 1378842
    Signed-off-by: Samikshan Bairagya <samikshan>
    Reviewed-on: http://review.gluster.org/15563
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Atin Mukherjee <amukherj>

Comment 12 Shyamsundar 2017-03-06 17:27:39 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.10.0, please open a new bug report.

glusterfs-3.10.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2017-February/030119.html
[2] https://www.gluster.org/pipermail/gluster-users/