Bug 1378905

Summary:	Incorrect error code returned from krb5_child
Product:	Red Hat Enterprise Linux 7	Reporter:	Dan Lavu <dlavu>
Component:	sssd	Assignee:	Lukas Slebodnik <lslebodn>
Status:	CLOSED NOTABUG	QA Contact:	Steeve Goveas <sgoveas>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.3	CC:	grajaiya, jhrozek, lslebodn, mkosek, mzidek, pbrezina
Target Milestone:	rc	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-14 09:37:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Dan Lavu 2016-09-23 13:28:39 UTC

Description of problem:

It seems that the exit status has changed causing the following automated test that is used for regression testing to fail.

Test suite: ad parameters
Test Case: sss_ssh_knownhostsproxy001: bz 1071823 segfault when HostID back end target is not configured

NOTE, this is not a blocker, the user is still permitted to login, only the error code has changed. 

Version-Release number of selected component (if applicable):


How reproducible:

Always

Steps to Reproduce:
1. Run ad_parameters test suite

Actual results:

:: [   PASS   ] :: Command 'ssh_user_password_login testuser01-1511559 Secret123' (Expected 0, got 0)
:: [   PASS   ] :: File '/var/log/messages' should not contain 'sssd_be\[[0-9]*\]: segfault' 
:: [   FAIL   ] :: File '/var/log/sssd/sssd_sssdad.com.log' should contain 'HostID back end target is not configured' 


Expected results:

:: [   PASS   ] :: Command 'ssh_user_password_login testuser01-1511559 Secret123' (Expected 0, got 0)
:: [   PASS   ] :: File '/var/log/messages' should not contain 'sssd_be\[[0-9]*\]: segfault' 
:: [   PASS   ] :: File '/var/log/sssd/sssd_sssdad.com.log' should contain 'HostID back end target is not configured' 


Additional info:

Previous patch that caused this bug.

https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org/thread/OM2BME5DKH3HBD23BB5SC73I5VTATIGD/#FFKZZXSHZXYIC3P6H3P4Z5INSPEZD6MC

Comment 1 Jakub Hrozek 2016-09-23 13:33:21 UTC

Upstream ticket:
https://fedorahosted.org/sssd/ticket/3198

Comment 2 Jakub Hrozek 2016-09-23 13:34:36 UTC

temporarily assigning to Lukas because he has some kind of a patch (even though it might need more work)

Comment 5 Lukas Slebodnik 2016-09-28 17:39:21 UTC

(In reply to Dan Lavu from comment #0)
> Description of problem:
> 
> It seems that the exit status has changed causing the following automated
> test that is used for regression testing to fail.
> 
> Test suite: ad parameters
> Test Case: sss_ssh_knownhostsproxy001: bz 1071823 segfault when HostID back
> end target is not configured
> 
> NOTE, this is not a blocker, the user is still permitted to login, only the
> error code has changed. 
> 
> Version-Release number of selected component (if applicable):
> 
> 
> How reproducible:
> 
> Always
> 
> Steps to Reproduce:
> 1. Run ad_parameters test suite
> 
> Actual results:
> 
> :: [   PASS   ] :: Command 'ssh_user_password_login
> testuser01-1511559 Secret123' (Expected 0, got 0)
> :: [   PASS   ] :: File '/var/log/messages' should not contain
> 'sssd_be\[[0-9]*\]: segfault' 
> :: [   FAIL   ] :: File '/var/log/sssd/sssd_sssdad.com.log' should contain
> 'HostID back end target is not configured' 
> 
> 
> Expected results:
> 
> :: [   PASS   ] :: Command 'ssh_user_password_login
> testuser01-1511559 Secret123' (Expected 0, got 0)
> :: [   PASS   ] :: File '/var/log/messages' should not contain
> 'sssd_be\[[0-9]*\]: segfault' 
> :: [   PASS   ] :: File '/var/log/sssd/sssd_sssdad.com.log' should contain
> 'HostID back end target is not configured' 
> 
The error message was removed as part of data provider refactoring

https://git.fedorahosted.org/cgit/sssd.git/commit/?id=dea636af4d1902a081ee891f1b19ee2f8729d759

Comment 6 Jakub Hrozek 2016-09-29 07:55:08 UTC

(In reply to Lukas Slebodnik from comment #5)
> The error message was removed as part of data provider refactoring
> 
> https://git.fedorahosted.org/cgit/sssd.git/commit/
> ?id=dea636af4d1902a081ee891f1b19ee2f8729d759

I think Dan linked a wrong test. This is about the confusion between locked and expired account.

Comment 7 Lukas Slebodnik 2016-10-14 09:37:15 UTC

Than it would be better to one a new bug with correct description.

Comment 8 Dan Lavu 2016-10-17 13:13:18 UTC

Sorry, I don't know where my head was that day, yes it was the wrong test. Here is the new ticket https://bugzilla.redhat.com/show_bug.cgi?id=1385665