Bug 1378976

Summary: Error When Trying to Create Service Dialog from Heat Orchestration Template
Product: Red Hat CloudForms Management Engine Reporter: Colin Arnott <carnott>
Component: AutomateAssignee: Bill Wei <bilwei>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: medium Docs Contact:
Priority: high    
Version: 5.6.0CC: benglish, bilwei, jhardy, mkanoor, obarenbo, simaishi, sshveta, tfitzger
Target Milestone: GAKeywords: TestOnly
Target Release: 5.8.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: openstack:stack:dialog
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1382818 1382819 (view as bug list) Environment:
Last Closed: 2017-06-12 17:28:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: Openstack Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1382818, 1382819    

Description Colin Arnott 2016-09-23 18:09:24 UTC 
Description of problem:
We receive an error when trying to create a Service Dialog from a Heat Orchestration Template. The error references that the Tab Basic Information / Label can't be blank, but there is no Basic Information to be found.

Version-Release number of selected component (if applicable):
cfme-5.6.1.2

How reproducible:
on this env: reliable

Actual results:
Error when creating a Service Dialogue from Orchestration Template: Validation failed: Dialogue :name / Tab Basic Information / Label can't be blank

Expected results:
successfully add the service dialogue to the orchestration template

Additional info:
evm.log line:
[----] E, [2016-09-22T12:46:04.409427 #11958:1688390] ERROR -- : MIQ(catalog_controller-service_dialog_from_ot_submit): Error when creating a Service Dialog from Orchestration Template: Validation failed: Dialog cp-Test_Dialog / Tab Basic Information / Label can't be blank
Comment 4 Bill Wei 2016-09-26 14:56:43 UTC 
Can you upload the heat template?
Comment 7 CFME Bot 2016-09-29 18:46:21 UTC 
https://github.com/ManageIQ/manageiq/pull/11589
Comment 8 Bill Wei 2016-09-29 18:57:08 UTC 
According to the heat template spec http://docs.openstack.org/developer/heat/template_guide/hot_spec.html#parameter-groups-section

The parameter group needs to have a label and description. That's what our code expects:
parameter_groups:
- label: <human-readable label of parameter group>
  description: <description of the parameter group>
  parameters:
  - <param name>
  - <param name>

This customer's parameter group does not have a label nor a description.
parameter_groups:
- parameters:
  - key_name
- parameters:
  - flavor
  - image

The fix to the dialog generation service is to automatically label a unlabeled parameter group. They will have labels such as "Parameter Group1", "Parameter Group2" etc.
Comment 9 CFME Bot 2016-09-30 14:26:06 UTC 
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/833a3805c76d4b03886a538a1d9ba723f9a92df8

commit 833a3805c76d4b03886a538a1d9ba723f9a92df8
Author:     Bill Wei <bilwei>
AuthorDate: Thu Sep 29 14:27:58 2016 -0400
Commit:     Bill Wei <bilwei>
CommitDate: Thu Sep 29 14:27:58 2016 -0400

    Handle the case that a parameter group does not have label
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1378976

 app/services/orchestration_template_dialog_service.rb       | 2 +-
 spec/fixtures/orchestration_templates/hot_parameters.yml    | 4 +---
 spec/models/orchestration_template_hot_spec.rb              | 4 ++--
 spec/services/orchestration_template_dialog_service_spec.rb | 2 +-
 4 files changed, 5 insertions(+), 7 deletions(-)
Comment 11 Bill Wei 2016-10-03 13:59:33 UTC 
euwe/backported
Comment 16 Shveta 2017-04-28 19:23:45 UTC 
Fixed in 5.8.0.12-rc1.20170425180304_4f35996