| Summary: | [RFE] update ovirt-engine-nodejs-modules dependencies | ||
|---|---|---|---|
| Product: | [oVirt] cockpit-ovirt | Reporter: | Sandro Bonazzola <sbonazzo> |
| Component: | RFE | Assignee: | Tomas Jelinek <tjelinek> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | dguo |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | --- | CC: | bugs, cshao, dguo, huzhao, jiawu, mlibra, oourfali, qiyuan, tjelinek, vszocs, weiwang, yaniwang, ycui, yzhao |
| Target Milestone: | --- | Keywords: | FutureFeature, Improvement |
| Target Release: | --- | Flags: | rule-engine:
planning_ack?
rule-engine: devel_ack? rule-engine: testing_ack? |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-11-21 14:23:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Sandro Bonazzola
2016-09-24 08:54:07 UTC
ovirt-engine-nodejs-modules dependencies needs to be updated and depending projects like cockpit-ovirt verified. ovirt-engine-nodejs-modules will use Yarn instead of npm to manage all dependencies, including: - downloading dependencies and generating LICENSES file during RPM build - locking down versions of all dependencies - detecting outdated dependencies and upgrading them to latest version (this must be done manually) The associated patch documents the process via README file. OK, just realized this RFE is for cockpit-ovirt component.
Please note that we're in the process of moving ovirt-engine-{nodejs,nodejs-modules} out of `releng-tools` repo and making changes to nodejs-modules package (use Yarn & rework the build script) so all consuming projects should be updated once the changes are done & std. CI makes new RPMs available.
(In reply to vszocs from comment #3) > OK, just realized this RFE is for cockpit-ovirt component. > > Please note that we're in the process of moving > ovirt-engine-{nodejs,nodejs-modules} out of `releng-tools` repo and making > changes to nodejs-modules package (use Yarn & rework the build script) so > all consuming projects should be updated once the changes are done & std. CI > makes new RPMs available. Before qa_ack, could you help to provide the steps or info about how to verify this RFE. or if you could help to verify, since QE not familiar with npm, yarn, and these dependencies? Thanks (In reply to dguo from comment #4) > Before qa_ack, could you help to provide the steps or info about how to > verify this RFE. > or if you could help to verify, since QE not familiar with npm, yarn, and > these dependencies? Thanks Both ovirt-engine-nodejs & ovirt-engine-nodejs-modules projects now live in their dedicated git repos: https://gerrit.ovirt.org/#/admin/projects/ovirt-engine-nodejs https://gerrit.ovirt.org/#/admin/projects/ovirt-engine-nodejs-modules ovirt-engine-nodejs = Node.js platform binary, packaged as RPM, used to build oVirt JavaScript applications. Build time dependency. ovirt-engine-nodejs-modules = Single RPM containing all JavaScript modules needed to build all oVirt JavaScript applications. Build time dependency. The task here is to verify that cockpit-ovirt RPM can still be built with above mentioned projects, which implies that cockpit-ovirt uses Yarn instead of npm. cockpit-ovirt falls under Virt team so I'm assigning this BZ to Tomas. According to comment above, this should be verified during build process, QE will do the sanity test after that. Thus, consider to change the QA contact as assignee. Tomas, your thought? A couple of recent cockpit-ovirt releases were built ok. I can confirm, another dependent ovirt-web-ui package builds recently ok as well. I think this bug can be closed. Thank you Marek, closing |