| Summary: | lvm2-activation.service has extra space in dependencies | ||
|---|---|---|---|
| Product: | [Community] LVM and device-mapper | Reporter: | Timur Bakeyev <timur> |
| Component: | lvm2 | Assignee: | LVM and device-mapper development team <lvm-team> |
| lvm2 sub component: | Other | QA Contact: | cluster-qe <cluster-qe> |
| Status: | CLOSED CURRENTRELEASE | Docs Contact: | |
| Severity: | low | ||
| Priority: | unspecified | CC: | agk, heinzm, jbrassow, msnitzer, prajnoha, zkabelac |
| Version: | 2.02.165 | Flags: | rule-engine:
lvm-technical-solution?
rule-engine: lvm-test-coverage? |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-08-06 00:52:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Applied, thanks! https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=70be57c8dab4a011b0f6014636d3948d10ddd8c3 The patch is scheduled for lvm2 v2.02.166. |
Description of problem: Not really a problem, but rather inaccuracy(?). Generated by lvm2-activation-generator lvm2-activation.service gets After dependency line with extra leading space: DefaultDependencies=no After= lvm2-activation-early.service cryptsetup.target Before=local-fs-pre.target shutdown.target Wants=systemd-udev-settle.service That's not an issue, really(so far?), but would be nice to get it as: After=lvm2-activation-early.service cryptsetup.target --- lvm2_activation_generator_systemd_red_hat.c.orig 2016-09-24 16:44:28.741513727 +0200 +++ lvm2_activation_generator_systemd_red_hat.c 2016-09-24 16:44:42.169437227 +0200 @@ -137,7 +137,7 @@ fputs("After=systemd-udev-settle.service\n" "Before=cryptsetup.target\n", f); } else - fprintf(f, "After= %s cryptsetup.target\n", unit_names[UNIT_EARLY]); + fprintf(f, "After=%s cryptsetup.target\n", unit_names[UNIT_EARLY]); fputs("Before=local-fs-pre.target shutdown.target\n" "Wants=systemd-udev-settle.service\n\n"