Bug 1379284

+++ This bug was initially created as a clone of Bug #1378492 +++

+++ This bug was initially created as a clone of Bug #1378484 +++

Description of problem:
-----------------------
Executing the 'gluster volume status' generates the warning message in glusterd.log.

The warning message goes like this :
<snip>
 "W [MSGID: 106217] [glusterd-op-sm.c:4706:glusterd_op_modify_op_ctx] 0-management: Failed uuid to hostname conversion"
</snip>

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
Layered installation - RHGS 3.2.0 (interim build - glusterfs-3.8.4-1.el7rhgs )
on RHEL 7.2

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Create any type of volume 
2. Start the volume
3. Execute 'gluster volume status'

Actual results:
---------------
Warning message seen in the glusterd.log

Expected results:
-----------------
Clean pass of the 'gluster volume status' command

Additional info:
----------------
The error snippet :
<snip>
[2016-09-22 09:21:38.536538] I [MSGID: 106499] [glusterd-handler.c:4360:__glusterd_handle_status_volume] 0-management: Received status volume req for volume test
[2016-09-22 09:21:38.537509] W [MSGID: 106217] [glusterd-op-sm.c:4706:glusterd_op_modify_op_ctx] 0-management: Failed uuid to hostname conversion
[2016-09-22 09:21:38.537533] W [MSGID: 106387] [glusterd-op-sm.c:4812:glusterd_op_modify_op_ctx] 0-management: op_ctx modification failed
</snip>

--- Additional comment from Worker Ant on 2016-09-22 10:58:50 EDT ---

REVIEW: http://review.gluster.org/15547 (glusterd: fix return val in glusterd_op_modify_op_ctx ()) posted (#1) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Atin Mukherjee on 2016-09-22 11:13:21 EDT ---

RCA:

As gNFS has been disabled by default, glusterd_op_volume_dict_uuid_to_hostname () has started misbehaving given its idx_max has been now reduced by one process. The issue in this function is although dict get failures are ignored but ret codes are not reset back to 0.

--- Additional comment from Worker Ant on 2016-09-22 11:15:58 EDT ---

REVIEW: http://review.gluster.org/15547 (glusterd: fix return val in glusterd_op_volume_dict_uuid_to_hostname ()) posted (#2) for review on master by Atin Mukherjee (amukherj)

--- Additional comment from Worker Ant on 2016-09-26 05:15:59 EDT ---

COMMIT: http://review.gluster.org/15547 committed in master by Kaushal M (kaushal) 
------
commit 3bf8f05a8a0eccd723a9478a5c925d099a145a1a
Author: Atin Mukherjee <amukherj>
Date:   Thu Sep 22 20:04:12 2016 +0530

    glusterd: fix return val in glusterd_op_volume_dict_uuid_to_hostname ()
    
    glusterd_op_volume_dict_uuid_to_hostname () ignores few dict_get_str failures
    but doesn't reset the ret value to 0.
    
    Reproducer steps:
    1. Configure a volume and start it (gNFS has to be disabled)
    2. gluster volume status
    
    An warning log is observed with:
    [MSGID: 106217] [glusterd-op-sm.c:4706:glusterd_op_modify_op_ctx] 0-management:
    Failed uuid to hostname conversion
    [2016-09-22 09:21:38.537533] W [MSGID: 106387]
    [glusterd-op-sm.c:4812:glusterd_op_modify_op_ctx] 0-management: op_ctx
    modification failed
    
    Change-Id: I1d3aa79304d83a9d5db1b7198773d8c2780e24a9
    BUG: 1378492
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/15547
    Smoke: Gluster Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Samikshan Bairagya <samikshan>
    Reviewed-by: Kaushal M <kaushal>