| Summary: | RFE: virt-p2v should support mnemonic operations | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Xiaodai Wang <xiaodwan> | ||||||||
| Component: | libguestfs | Assignee: | Pino Toscano <ptoscano> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 7.3 | CC: | juzhou, mtessun, mxie, mzhan, ptoscano, rjones, tzheng | ||||||||
| Target Milestone: | rc | Keywords: | FutureFeature | ||||||||
| Target Release: | 7.4 | ||||||||||
| Hardware: | x86_64 | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | P2V | ||||||||||
| Fixed In Version: | libguestfs-1.36.2-3.el7 | Doc Type: | If docs needed, set a value | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2017-08-01 22:11:26 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Bug Depends On: | 1359086 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Xiaodai Wang
2016-09-26 09:35:58 UTC
I think these are called accelerator keys? (In reply to Richard W.M. Jones from comment #1) > I think these are called accelerator keys? yep, sorry for confusing. :). I saw 'mnemonics' in developer.gnome.org. Labels may contain “mnemonics”. Mnemonics are underlined characters in the label, used for keyboard navigation. Mnemonics are created by providing a string with an underscore before the mnemonic character, such as "_File", Fixed upstream with https://github.com/libguestfs/libguestfs/commit/7f236d2201e1063570ac18b118e83b31c778f304 which is in libguestfs >= 1.35.7. I could reproduce this bug with build: virt-p2v-1.32.7-2.el7.iso Verify the bug with builds: virt-v2v-1.36.2-2.el7.x86_64 libguestfs-1.36.2-2.el7.x86_64 virt-p2v-1.36.2-2.el7 Steps: 1. Making virt-p2v bootable usb key via virt-p2v-make-disk command # virt-p2v-make-disk -o /dev/sdb [ 2.9] Downloading: http://libguestfs.org/download/builder/fedora-25.xz ######################################################################## 100.0% *********** [6814.6] Finishing off Output file: /dev/sdb Output size: 14.9G Output format: raw Total usable space: 14.3G Free space: 12.7G (89%) ************* 2.Insert the p2v bootable usb key into the machine and then boot the machine into p2v client 3.Checking the mnemonic characters at p2v GUI interface 4.After finishing checking, found some buttons has no mnemonic characters or some mnemonic characters are conflict 4.1 At inputting v2v conversion server info interface-> configure network-> add -> type 'alt' keyboard-> found create button has no mnemonic character, pls refer to screenshot 'create' 4.2 At inputting v2v conversion server info interface-> configure network-> select one network, such as 'eth0' -> edit-> select 'DCB' option-> type 'alt' keyboard-> found 'Use 802.1X ..' option has no mnemonic character, pls refer to screenshot 'DCB' 4.3 At inputting conversion info interface-> type 'alt' keyboard-> found mnemonic character of 'output storage' and mnemonic character of 'start conversion' are conflict, pls refer to screenshot 'mnemonic-S' So this bug still need to be fixed above issues Created attachment 1264715 [details]
create
Created attachment 1264716 [details]
DCB
Created attachment 1264717 [details]
mnemonic-S
'create' and 'DCB' are part of a dialog provided by NetworkManager's "nm-connection-editor" tool, so you would have to file a separate bug about those against NetworkManager. I can fix the conflicting output storage / start conversion ones today. I have filed the bug 1434317 to track the problem of 'create' and 'DCB' buttons Patch posted to fix comment 9: https://www.redhat.com/archives/libguestfs/2017-March/msg00238.html Upstream commit: 9d6b1ec28811255ec4447e3f67eb508f0b6f8396 in libguestfs >= 1.37.7. Verify the bug with builds again: virt-v2v-1.36.2-3.el7.x86_64 libguestfs-1.36.2-3.el7.x86_64 virt-p2v-1.36.2-3.el7 Steps: 1. Making virt-p2v bootable usb key via virt-p2v-make-disk command # virt-p2v-make-disk -o /dev/sdb rhel-7.3 2.Insert the p2v bootable usb key into the machine and then boot the machine into p2v client 3.Checking the mnemonic characters at p2v GUI interface 4.After finishing checking, all buttons have mnemonic characters except that 'DCB' and 'create' which there is bug1434317 to track Result: The bug has been fixed, so move the bug from ON_QA to VERIFIED Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2023 |