Bug 1379393 (pavucontrol-qt)

Summary:	Review Request: pavucontrol-qt - Qt port of volume control pavucontrol
Product:	[Fedora] Fedora	Reporter:	Helio Chissini de Castro <helio>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, rdieter, sudhir
Target Milestone:	---	Flags:	rdieter: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-07 11:42:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	928937

Description Helio Chissini de Castro 2016-09-26 14:54:41 UTC

Spec URL: https://heliocastro.fedorapeople.org/pavucontrol-qt/pavucontrol-qt.spec
SRPM URL: https://heliocastro.fedorapeople.org/pavucontrol-qt/pavucontrol-qt-0.1.0-1.fc24.src.rpm
Description: Qt port of volume control pavucontrol
Fedora Account System Username: heliocastro

Comment 1 Rex Dieter 2016-09-26 14:58:00 UTC

I can review today (or tomorrow)

Comment 2 Rex Dieter 2016-09-26 17:33:00 UTC

naming: ok

license: ok

1.  could/should leave out:
BuildRequires: %{?fedora:cmake}%{!?fedora:cmake3} >= 3.0
that dependency should be handled by whatever package that provides the 
%{cmake_lxqt} 
macro

macros: ok

2.  should consider adjusting pavucontrol-qt.desktop Name/GenericNameComment somehow, it currently appears exactly the same as pavucontrol, so it's hard/impossible to distinguish which is which, contains:
Name=PulseAudio Volume Control
GenericName=Volume Control
Comment=Adjust the volume level
(not a blocker, mostly a suggestion for pavucontrol-qt upstream)

scriptlets: ok (n/a)

sources: ok
32217c5ae8a846e92548a55b8d3b9267  pavucontrol-qt-0.1.0.tar.xz


otherwise, package is fairly simple and clean, 
APPROVED