Bug 1379457

Description of problem:

For metrics missing help information the "pminfo -t" and "pminfo -T" returning a misleading error message:

Error: Unknown or illegal metric identifier

Would expect PM_ERR_TEXT with the following string to be printed in these cases:

"One-line or help text is not available"

Also would expect it not to put in the additional blank lines in the output.

Version-Release number of selected component (if applicable):
pcp-3.11.4-1.fc24.x86_64

How reproducible: Always


Steps to Reproduce:
1. sudo yum install pcp
2.$ pminfo -t disk.dev

Actual results:

$ pminfo -t disk.dev
disk.dev.read [per-disk read operations]
disk.dev.write [per-disk write operations]
disk.dev.total [per-disk total (read+write) operations]
disk.dev.blkread [per-disk block read operations]
disk.dev.blkwrite [per-disk block write operations]
disk.dev.blktotal [per-disk total (read+write) block operations]
disk.dev.read_bytes [per-disk count of bytes read]
disk.dev.write_bytes [per-disk count of bytes written]
disk.dev.total_bytes [per-disk count of total bytes read and written]
disk.dev.read_merge [per-disk count of merged read requests]
disk.dev.write_merge [per-disk count of merged write requests]
disk.dev.avactive [per-disk count of active time]
disk.dev.read_rawactive [per-disk raw count of read response time]
disk.dev.write_rawactive [per-disk raw count of write response time]
disk.dev.total_rawactive [per-disk raw count of I/O response time]
disk.dev.aveq [per-disk time averaged count of request queue length]
disk.dev.scheduler [per-disk I/O scheduler]
disk.dev.await One-line Help: Error: Unknown or illegal metric identifier

disk.dev.r_await One-line Help: Error: Unknown or illegal metric identifier

disk.dev.w_await One-line Help: Error: Unknown or illegal metric identifier

disk.dev.avg_qlen One-line Help: Error: Unknown or illegal metric identifier

disk.dev.avg_rqsz One-line Help: Error: Unknown or illegal metric identifier

disk.dev.util One-line Help: Error: Unknown or illegal metric identifier




Expected results:

$ pminfo -t disk.dev
disk.dev.read [per-disk read operations]
disk.dev.write [per-disk write operations]
disk.dev.total [per-disk total (read+write) operations]
disk.dev.blkread [per-disk block read operations]
disk.dev.blkwrite [per-disk block write operations]
disk.dev.blktotal [per-disk total (read+write) block operations]
disk.dev.read_bytes [per-disk count of bytes read]
disk.dev.write_bytes [per-disk count of bytes written]
disk.dev.total_bytes [per-disk count of total bytes read and written]
disk.dev.read_merge [per-disk count of merged read requests]
disk.dev.write_merge [per-disk count of merged write requests]
disk.dev.avactive [per-disk count of active time]
disk.dev.read_rawactive [per-disk raw count of read response time]
disk.dev.write_rawactive [per-disk raw count of write response time]
disk.dev.total_rawactive [per-disk raw count of I/O response time]
disk.dev.aveq [per-disk time averaged count of request queue length]
disk.dev.scheduler [per-disk I/O scheduler]
disk.dev.await One-line Help: Error: One-line or help text is not available
disk.dev.r_await One-line Help: Error: One-line or help text is not available
disk.dev.w_await One-line Help: Error: One-line or help text is not available
disk.dev.avg_qlen One-line Help: Error: One-line or help text is not available
disk.dev.avg_rqsz One-line Help: Error: One-line or help text is not available
disk.dev.util One-line Help: Error: One-line or help text is not available