Bug 1379544

Summary: glusterd creates all rpc_clnts with the same name
Product: [Community] GlusterFS Reporter: Kaushal <kaushal>
Component: glusterdAssignee: bugs <bugs>
Status: CLOSED NOTABUG QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: mainlineCC: amukherj, atumball, bugs, kaushal
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-09 20:15:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kaushal 2016-09-27 05:56:41 UTC 
Description of problem:
GlusterD create rpc_clnts for every peer it connects to. But all the rpc_clnts are created with `this->name`, ie. GlusterD's xlator name '0-management', as the name.

This makes it problematic when attempting to identify socket_connect failures of GlusterD rpc_clnts. `socket_connect()` logs connect failures with,
```
gf_log (this->name, ((sa_family == AF_UNIX) ? GF_LOG_DEBUG : GF_LOG_ERROR), "connection attempt on %s failed, (%s)", this->peerinfo.identifier, strerror (errno));
```

This log is basically useless for identifying connect to which remote endpoint failed, as `this->name` is the same for all GlusterD rpc_clnt transports and `peerinfo->identifier` is only filled after a successful connect.
Comment 2 Yaniv Kaul 2019-04-17 11:47:15 UTC 
Current status?
Comment 3 Amar Tumballi 2019-05-09 20:15:36 UTC 
This bug is not valid, as what we are logging with 'this->peerinfo.identifier' is what matters here.
Comment 4 Red Hat Bugzilla 2023-09-14 03:31:26 UTC 
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days