Bug 1379636

Summary:	can not change node schedulable with oadm
Product:	OpenShift Container Platform	Reporter:	Wenkai Shi <weshi>
Component:	oc	Assignee:	Maru Newby <mnewby>
Status:	CLOSED ERRATA	QA Contact:	Xingxing Xia <xxia>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.4.0	CC:	aos-bugs, bbennett, jokerman, mifiedle, mmccomas, tdawson, wabouham
Target Milestone:	---
Target Release:	3.4.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:	no doc update	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-01-18 12:41:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Wenkai Shi 2016-09-27 09:28:01 UTC

Description of problem:
Can not change node schedulable with oadm, there is no "PUT" seen from --loglevel=6 while change schedulable, but in oc 3.3 there is "PUT".

Version-Release number of selected component (if applicable):
atomic-openshift 3.4.0.3
openshift-ansible 3.4.2

How reproducible:
100%

Steps to Reproduce:
[root@openshift-129 ~]# oc get nodes 
master.example.com   Ready     38m
node1.example.com   Ready     38m
node2.example.com   Ready     38m

[root@openshift-129 ~]# oadm manage-node master.example.com --schedulable=false --loglevel=6
...
I0927 04:56:23.510042   20210 round_trippers.go:318] GET https://master.example.com:8443/api/v1/nodes/master.example.com 200 OK in 3 milliseconds
NAME                                   STATUS    AGE
master.example.com   Ready     39m

Actual results:
Schedulable didn't change

Expected results:
Schedulable should be change to "SchedulingDisabled"

Comment 1 Mike Fiedler 2016-09-29 17:51:46 UTC

The  installer is unable to set the masters unschedulable as well.

Comment 2 Walid A. 2016-09-29 18:04:41 UTC

One workaround was to use the command: kubectl patch nodes <node-ip> -p '{"spec": {"unschedulable": true}}'

Comment 3 Maru Newby 2016-10-04 18:19:19 UTC

A fix was merged into origin master, see the linked github pull request.

Comment 4 Troy Dawson 2016-10-18 15:58:24 UTC

This has been merged into ose and is in OSE v3.4.0.12 or newer.

Comment 6 Wenkai Shi 2016-10-19 09:22:38 UTC

It fixed in this version.

[root@ansible ~]# rpm -qa | grep openshift-ansible
...
openshift-ansible-3.4.9-1.git.0.94af651.el7.noarch
...

[root@master ~]# openshift version
openshift v3.4.0.12
kubernetes v1.4.0+776c994
etcd 3.1.0-alpha.1

[root@master ~]# oc get nodes 
NAME               STATUS                     AGE
node1.example.com   Ready                      24m
master.example.com   Ready,SchedulingDisabled   24m
node2.example.com   Ready                      24m

[root@master ~]# oadm manage-node master.example.com --schedulable=true
NAME                                   STATUS    AGE
master.example.com   Ready     28m

[root@master ~]# oadm manage-node master.example.com --schedulable=false
NAME                                   STATUS                     AGE
master.example.com   Ready,SchedulingDisabled   29m

Comment 7 Maru Newby 2016-12-14 22:43:58 UTC

Does this bug require doc text or target release?  afaik this was caught before release.

Comment 8 Ben Bennett 2017-01-13 15:19:38 UTC

Maru: 

Target release - yes.

Doc text - no.  Just set the type to 'no doc update'

Comment 10 errata-xmlrpc 2017-01-18 12:41:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:0066