Bug 1379754

Summary: Host can't be removed (FE exception)
Product: [oVirt] ovirt-engine Reporter: jniederm
Component: Frontend.WebAdminAssignee: Ramesh N <rnachimu>
Status: CLOSED CURRENTRELEASE QA Contact: SATHEESARAN <sasundar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.1.0CC: bugs, gklein, sabose, tnisan
Target Milestone: ovirt-4.1.0-alphaFlags: rule-engine: ovirt-4.1+
rule-engine: planning_ack+
rule-engine: devel_ack+
sasundar: testing_ack+
Target Release: 4.1.0.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-04-27 09:36:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
stacktrace.txt none

Description jniederm 2016-09-27 15:10:58 UTC
Created attachment 1205267 [details]
stacktrace.txt

Description of problem:
FE exception is thrown when "Remove" button is clicked on a host.

Version-Release number of selected component (if applicable):
4.1 master, commit 0e71dd7

How reproducible:
100%

Steps to Reproduce:
1. Make sure there is a cluster with only one host in maintenance state.
2. Select the host in webadmin
3. Click "Remove" in toolbar

Actual results:
FE exception is thrown (pink box on upstream, message in browser console)

Expected results:
Host is removed

Additional info:

Comment 1 jniederm 2016-09-27 16:18:34 UTC
The problem relates to patch https://gerrit.ovirt.org/#/c/59102/. Method HostListModel.remote() creates confirmation model as instance of `ConfirmationModel` however HostModule.getHostListProvider() declares that confirmation will be processed by HostMaintenanceConfirmationPopupPresenterWidget that expects instance of HostMaintenanceConfirmationModel.

Assigning to author of the patch.

Comment 2 Tal Nisan 2016-09-27 16:32:43 UTC
The root cause is indeed that patch but Ramesh is from the Gluster team, not storage :)

Comment 3 Ramesh N 2016-09-28 04:26:39 UTC
(In reply to jniederm from comment #1)
> The problem relates to patch https://gerrit.ovirt.org/#/c/59102/. Method
> HostListModel.remote() creates confirmation model as instance of
> `ConfirmationModel` however HostModule.getHostListProvider() declares that
> confirmation will be processed by
> HostMaintenanceConfirmationPopupPresenterWidget that expects instance of
> HostMaintenanceConfirmationModel.
> 
> Assigning to author of the patch.

Sorry for the regression. Let me send a patch to fix it ASAP.

Comment 4 Sandro Bonazzola 2016-12-12 13:54:04 UTC
The fix for this issue should be included in oVirt 4.1.0 beta 1 released on December 1st. If not included please move back to modified.

Comment 5 SATHEESARAN 2017-04-05 10:36:46 UTC
Tested with RHV 4.1.1-6.

When the hosts is already in maintenance, trying to remove the host doesn't generate any FE exception