Bug 1379778

Issues:
- I have rpmlint errors about non-executable-script for diff_match_patch/diff_match_patch.py and diff_match_patch/diff_match_patch_test.py. Can you remove the sheband on those files, it is not needed.

Non blocking remarks:
- The definition of the %sum macro is not needed. Just put the text in the main Summary and use %{summary}. You can define a %desc macro for the description though.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[X]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[X]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated". 6 files have unknown
     license. Detailed output of licensecheck in /tmp/1379778-python-diff-
     match-patch/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
     names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[X]: Python eggs must not download any dependencies during the build
     process.
[X]: A package which is used by another package via an egg interface should
     provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -diff-match-patch , python3-diff-match-patch
[?]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python2-diff-match-patch-20121119-1.fc26.noarch.rpm
          python3-diff-match-patch-20121119-1.fc26.noarch.rpm
          python-diff-match-patch-20121119-1.fc26.src.rpm
python2-diff-match-patch.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/diff_match_patch/diff_match_patch.py 644 /usr/bin/python2.4 
python2-diff-match-patch.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/diff_match_patch/diff_match_patch_test.py 644 /usr/bin/python2.4 
python3-diff-match-patch.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/diff_match_patch/diff_match_patch_test.py 644 /usr/bin/python2.4 
python3-diff-match-patch.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/diff_match_patch/diff_match_patch.py 644 /usr/bin/python2.4 
python-diff-match-patch.src:39: W: setup-not-quiet
3 packages and 0 specfiles checked; 4 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
python3-diff-match-patch.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/diff_match_patch/diff_match_patch_test.py 644 /usr/bin/python2.4 
python3-diff-match-patch.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/diff_match_patch/diff_match_patch.py 644 /usr/bin/python2.4 
python2-diff-match-patch.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/diff_match_patch/diff_match_patch.py 644 /usr/bin/python2.4 
python2-diff-match-patch.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/diff_match_patch/diff_match_patch_test.py 644 /usr/bin/python2.4 
2 packages and 0 specfiles checked; 4 errors, 0 warnings.



Requires
--------
python3-diff-match-patch (rpmlib, GLIBC filtered):
    python(abi)

python2-diff-match-patch (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python3-diff-match-patch:
    python3-diff-match-patch
    python3.5dist(diff-match-patch)
    python3dist(diff-match-patch)

python2-diff-match-patch:
    python-diff-match-patch
    python2-diff-match-patch
    python2.7dist(diff-match-patch)
    python2dist(diff-match-patch)



Source checksums
----------------
https://pypi.python.org/packages/source/d/diff-match-patch/diff-match-patch-20121119.tar.gz :
  CHECKSUM(SHA256) this package     : 9dba5611fbf27893347349fd51cc1911cb403682a7163373adacc565d11e2e4c
  CHECKSUM(SHA256) upstream package : 9dba5611fbf27893347349fd51cc1911cb403682a7163373adacc565d11e2e4c


Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1379778
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

(In reply to Julien Enselme from comment #1)
> Issues:
> - I have rpmlint errors about non-executable-script for
> diff_match_patch/diff_match_patch.py and
> diff_match_patch/diff_match_patch_test.py. Can you remove the sheband on
> those files, it is not needed.
> 
> Non blocking remarks:
> - The definition of the %sum macro is not needed. Just put the text in the
> main Summary and use %{summary}. You can define a %desc macro for the
> description though.

Thanks for the comments! I updated the .spec and .srpm in place, and the errors and remarks should be fixed.

> the errors and remarks should be fixed.

They are. I now get this:

python3-diff-match-patch.noarch: E: description-line-too-long C The Diff Match and Patch libraries offer robust algorithms to perform thenoperations required for synchronizing plain text.

It seems in you new spec file, the desc line contains '\n' instead of a true line break. Can you fix that? After that, the package should be good.

BTW, the closing parenthesis is missing in your changelog entry.

(In reply to Julien Enselme from comment #3)
> They are. I now get this:
> 
> python3-diff-match-patch.noarch: E: description-line-too-long C The Diff
> Match and Patch libraries offer robust algorithms to perform thenoperations
> required for synchronizing plain text.
> 
> It seems in you new spec file, the desc line contains '\n' instead of a true
> line break. Can you fix that? After that, the package should be good.
> 
> BTW, the closing parenthesis is missing in your changelog entry.

Thanks! Both should now be fixed.

Looks good. Approved.

*** This bug has been marked as a duplicate of bug 1370871 ***

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-diff-match-patch

*** Bug 1370871 has been marked as a duplicate of this bug. ***

python-diff-match-patch-20121119-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-33ab2cbca7

python-diff-match-patch-20121119-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5448ceeb3c

python-diff-match-patch-20121119-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-33ab2cbca7

python-diff-match-patch-20121119-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5448ceeb3c

python-diff-match-patch-20121119-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

python-diff-match-patch-20121119-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.