| Summary: | Review Request: pdc-updater - Update the product definition center in response to fedmsg | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-12-04 02:50:07 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Ralph Bean
2016-09-27 19:25:45 UTC
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15831727 %{!?_licensedir: %global license %%doc}
%if 0%{?rhel} && 0%{?rhel} <= 6
%{!?__python2: %global __python2 /usr/bin/python2}
%{!?python2_sitelib: %global python2_sitelib %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python2_sitearch: %global python2_sitearch %(%{__python2} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif
I think this is all unnecessary, tibbs packported the macros.
Group → not necessary [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections].
.egg-info doesn't have to be removed (it's not a "binary egg" that the guidelines talk about).
%py2_build
%py2_install
Source0 returns 404.
Is python3 support out of question?
Unfortunately, py3 support is out of the question until fedmsg supports py3 (which is in turned blocked on certain x509 functionality being added to python-cryptography upstream so we can get of M2Crypto). OK, the following release should address all your other comments: Spec URL: http://threebean.org/rpm/SPECS/pdc-updater.spec SRPM URL: http://threebean.org/rpm/SRPMS/pdc-updater-0.4.0-1.fc25.src.rpm Here's a successful epel7 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16699608 According to the guidelines, Provides: python2-pdc-updater must be added [https://fedoraproject.org/wiki/Packaging:Python#Provides]. + package name is OK + latest version + license is acceptable (LGPGv2+) + license is specified correctly + R/BR look correct - Provides look OK, with one exception, see note above + builds and installs OK + no scriptlets necessary You could replace: %{__python2} setup.py build with %py2_build and %{__python2} setup.py install -O1 --skip-build --root=%{buildroot} with %py2_install. Package is APPROVED, please fix up the Provides when importing. Actually, %python_provide should also be used.
Please add %{?python_provide:%python_provide python2-%name}
Good call! I'll make the update. Specifically, I'll make the change before importing to SCM. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/pdc-updater pdc-updater-0.4.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f82682427a pdc-updater-0.4.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f82682427a pdc-updater-0.4.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |