Bug 1380127

Summary: Do not register default EC and RSA methods
Product: [Fedora] Fedora Reporter: David Woodhouse <dwmw2>
Component: libp11Assignee: Nikos Mavrogiannopoulos <nmavrogi>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: dwmw2, klember, nmavrogi, tmraz
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-08 17:39:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1380125    
Bug Blocks:    

Description David Woodhouse 2016-09-28 17:34:14 UTC
We shouldn't advertise generic RSA and EC methods in engine_pkcs11. If someone calls ENGINE_set_default() they might actually get *used* for software keys.. and they won't work.

https://github.com/OpenSC/libp11/issues/107

We need to fix OpenSSL bug 1380125 before we ship the fix for this.

Comment 1 Tomas Mraz 2016-09-29 08:05:28 UTC
What about 3rd party applications, do they call ENGINE_init?

Comment 2 David Woodhouse 2016-09-29 09:26:50 UTC
Yes, they must. They mostly don't need to call ENGINE_set_default(), because that's pointless. They *do* need to use ENGINE_init().

For openssl s_client what happened wa they forgot to call ENGINE_init(), but for engines which *did* provide generic methods (as engine_pkcs11 did but shouldn't), they got away with it because SSL_set_default() implicitly initialised the engine.

The OpenSSL fix has been changed, and it's uncovered a separate bug we need to fix in libp11: https://github.com/openssl/openssl/pull/1643

Comment 3 Fedora End Of Life 2017-07-25 23:16:15 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 4 Fedora End Of Life 2017-08-08 17:39:37 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.