Bug 1380144

Summary: [RFE] create a --fail-on-warning option
Product: Red Hat Enterprise Linux 7 Reporter: Greeshma Gopinath <ggopinat>
Component: rtevalAssignee: John Kacur <jkacur>
Status: CLOSED ERRATA QA Contact: Jiri Kastner <jkastner>
Severity: unspecified Docs Contact: Jana Heves <jsvarova>
Priority: medium    
Version: 7.2CC: bhu, jen, jkacur, williams
Target Milestone: rcKeywords: FutureFeature
Target Release: 7.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
This is part one of a fix to prevent tests from failing silently. We would rather have rteval exit with an error, instead of user getting unrealistic test results.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2018-04-10 18:14:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1442258    
Attachments:
Description Flags
Remove hack that sleeps if out-of-memory launching hackbench none

Description Greeshma Gopinath 2016-09-28 18:45:43 UTC 
Description of problem:
Automated testing environments need to have consistent tests running every time. Rteval warnings like failure to run hackbench stress due to low memory, might go undetected but they impact the accuracy of the results.There should be an option to trigger a failure in case of warnings. 


How reproducible:
Always

Steps to Reproduce:
1.Run rteval when there is less than 1Gb alloted per vcpu
2.Hackbench test does not run because of low memory
3.Other stresses/loads continue to run.

Actual results:
Warning is generated.

Expected results:
The test should have failed because of low memory.
Comment 1 Clark Williams 2016-09-30 19:07:56 UTC 
I have no problems adding a --fail-on-warn option in the NFV/7.4 release timeframe.
Comment 3 John Kacur 2017-09-25 14:40:29 UTC 
I see that in the particular case of hackbench, if there is an OSError due to not enough memory, hackbench is sleeping and waiting to see if some memory is freed up, which might be okay in a server environment, but not  what we want in a low-memory environment. This might be more the source of your problem, so I'm investigating whether there is a solution other than the proposed one.
Comment 4 John Kacur 2017-10-16 13:56:12 UTC 
Created attachment 1339246 [details]
Remove hack that sleeps if out-of-memory launching hackbench
Comment 5 John Kacur 2017-10-18 12:09:45 UTC 
It appears that this is of no help in a server environment either, so the solution is to remove this code and let rteval fail with an OSError due to not enough memory.

Fixed in 2.14-4 and up
Comment 18 errata-xmlrpc 2018-04-10 18:14:09 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0969