Bug 1380147

(In reply to Shivraj from comment #0)

> Expected results:
> should work

Just to clarify, 'should work' here means to avoid to show a traceback when the command fails to connect to the qemu process for setting the console password, printing a clean error message.

hosted-engine --add-console-password --password=FOO
just call:

vdsClient -s localhost setVmTicket "${vmid}" "${pass}" 120

So the traceback is generated by vdsClient.
Changing the component to vdsm.

Example of traceback:

# hosted-engine --add-console-password --password=FOO
Traceback (most recent call last):
  File "/usr/share/vdsm/vdsClient.py", line 3001, in <module>
    code, message = commands[command][0](commandArgs)
  File "/usr/share/vdsm/vdsClient.py", line 480, in do_setVmTicket
    params))
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1233, in __call__
    return self.__send(self.__name, args)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1587, in __request
    verbose=self.__verbose
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1273, in request
    return self.single_request(host, handler, request_body, verbose)
  File "/usr/lib64/python2.7/xmlrpclib.py", line 1303, in single_request
    response = h.getresponse(buffering=True)
  File "/usr/lib64/python2.7/httplib.py", line 1089, in getresponse
    response.begin()
  File "/usr/lib64/python2.7/httplib.py", line 444, in begin
    version, status, reason = self._read_status()
  File "/usr/lib64/python2.7/httplib.py", line 400, in _read_status
    line = self.fp.readline(_MAXLINE + 1)
  File "/usr/lib64/python2.7/socket.py", line 476, in readline
    data = self._sock.recv(self._rbufsize)
error: [Errno 104] Connection reset by peer

Moving to virt team.

Package: vdsm-4.17.35-1.el7ev.noarch

it works for normal VMs, so this is either a timing issue (e.g. requesting it when the VM is not in the right state), or the VM is not "registered" in vdsm it is not known and the request won't go through) - you should not mix managing the HE VM directly and through vdsm. 

To see if it is indeed the case I would suggest to check that such VM is listed in "list" output and then try setVmTicket.

(In reply to Michal Skrivanek from comment #7)
> it works for normal VMs, so this is either a timing issue (e.g. requesting
> it when the VM is not in the right state), or the VM is not "registered" in
> vdsm it is not known and the request won't go through) - you should not mix
> managing the HE VM directly and through vdsm. 
> 
> To see if it is indeed the case I would suggest to check that such VM is
> listed in "list" output and then try setVmTicket.

Not sure why this bug has been moved back to integration.
We're not maintaining vdsClient code and here the only issue is that vdsClient writes a traceback instead of a user friendly error.

because it is an integration issue. As noted in comment #8 it is either timing or wrong usage (to try to set a ticket at certain time). Each tool works ok on its own. Plus vdsClient is deprecated and unlikely to get a fix unless it is a security one.

So my suggestion would be to close this without a fix, or invest time to improve error reporting(or when you can/cannot set console) in hosted-engine tool, or remove that code and switch to serial console access only which is supposedly a bit more suitable for HE VM, and doesn't require further dependencies to access it.