Bug 1380177

Summary: Remove the Dependency on redhat-lsb-core Package from the ceph-base Package
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: Dustin Schoenbrun <dschoenb>
Component: RADOSAssignee: Brad Hubbard <bhubbard>
Status: CLOSED ERRATA QA Contact: shylesh <shmohan>
Severity: low Docs Contact:
Priority: low    
Version: 2.0CC: bhubbard, ceph-eng-bugs, dschoenb, dzafman, hnallurv, kchai, kdreyer
Target Milestone: rc   
Target Release: 2.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: RHEL: ceph-10.2.5-7.el7cp Ubuntu: ceph_10.2.5-3redhat1xenial Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-14 15:45:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Dustin Schoenbrun 2016-09-28 20:54:52 UTC
Description of problem:
When you attempt to install the ceph-base package it includes the redhat-lsb-core package as a dependency. This is a hold-over from RHCEPH 1.3 when redhat-lsb-core provided some functionality for the SystemV init scripts. With the init scripts gone, we should also remove the dependency on redhat-lsb-core

Version-Release number of selected component (if applicable):
ceph-base.x86_64 1:10.2.2-41.el7cp

How reproducible:
100%

Steps to Reproduce:
1. Install a RHEL 7.3 machine and set up the proper repositories
2. Install the ceph-base package
3. Observe that one of the dependencies is redhat-lsb-core.

Actual results:
The redhat-lsb-core package is a dependency of the ceph-base package.

Expected results:
You should be able to install the ceph-base package without requiring the redhat-lsb-core package.

Comment 2 Ken Dreyer (Red Hat) 2016-09-28 21:02:53 UTC
Besides supporting SysV init in RHCS 1.3 (now gone in RHCS 2), the latest code in master upstream also requires redhat-lsb-core, because collect_sys_info() shells out to lsb_release, as explained in http://tracker.ceph.com/issues/14906

We need a developer to remove the runtime calls to lsb_release. Is collect_sys_info() in src/common/util.cc the only place it's called at runtime? It's fine to keep it at build-time, but runtime implies that we'll have to pull in things we don't want or need.

An alternative would be to simply get the OS-specific values from /etc/os-release, which is present on all modern Linux distributions.

Comment 4 Brad Hubbard 2016-11-07 07:42:55 UTC
https://github.com/ceph/ceph/pull/11365 is merged in master. Do we want to request a backport to jewel?

Comment 5 Ken Dreyer (Red Hat) 2016-11-07 16:53:09 UTC
Personally I think so. I've updated http://tracker.ceph.com/issues/17425 to "Pending Backport" to indicate this.

Comment 17 errata-xmlrpc 2017-03-14 15:45:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2017-0514.html