Bug 1380197

Summary: Automate - Service provision pending email not being sent.
Product: Red Hat CloudForms Management Engine Reporter: William Fitzgerald <wfitzger>
Component: AutomateAssignee: William Fitzgerald <wfitzger>
Status: CLOSED CURRENTRELEASE QA Contact: Shveta <sshveta>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.7.0CC: cpelland, jhardy, mkanoor, obarenbo, simaishi, tfitzger
Target Milestone: GAKeywords: TestOnly
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: service:automate:provision
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1382816 1382817 (view as bug list) Environment:
Last Closed: 2017-06-12 16:16:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1382816, 1382817    

Description William Fitzgerald 2016-09-28 22:17:42 UTC 
Description of problem:
When service provisioning is set to 'manual' approval, the email(s) for the pending request are not being send.  Pending_request method is not running.


Version-Release number of selected component (if applicable):


How reproducible:
100%


Steps to Reproduce:
1. set service approval to manual
 (Service/Provisioning/StateMachines/ServiceProvisionRequestApproval/default)
2. run a service provision
3.

Actual results:
No email is sent.


Expected results:
Email(s) should be sent.

Additional info:
Comment 2 CFME Bot 2016-09-29 19:01:52 UTC 
https://github.com/ManageIQ/manageiq/pull/11590
Comment 3 CFME Bot 2016-09-30 18:11:38 UTC 
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/c412f87eef1292c61a74b01ba1d3c956c8ff79d5

commit c412f87eef1292c61a74b01ba1d3c956c8ff79d5
Author:     william fitzgerald <wfitzger>
AuthorDate: Wed Sep 28 18:23:02 2016 -0400
Commit:     william fitzgerald <wfitzger>
CommitDate: Wed Sep 28 18:23:02 2016 -0400

    Automate - Service provision pending email not being sent.
    
    Added logic for abort with log message when approval_type was 'manual'.
    
    This will now run pending_request and send the pending email(s).
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1380197

 .../__methods__/approve_request.rb                                     | 3 +++
 1 file changed, 3 insertions(+)
Comment 6 Shveta 2017-03-03 00:23:36 UTC 
Fixed.Getting email for pending request.
verified in 5.8.0.2-nightly.20170228141623_8710eed