Bug 1380343

Summary: [abrt] autofs: automount killed by SIGSEGV
Product: [Fedora] Fedora Reporter: Brian J. Murrell <brian>
Component: autofsAssignee: Ian Kent <ikent>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: brian, ikent
Target Milestone: ---Flags: ikent: needinfo? (brian)
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/7b6807185a4a5aaab65d185766f9832552c09af1
Whiteboard: abrt_hash:33433cc7cb78a6cf5f3a026ae2754f6027d11477;
Fixed In Version: autofs-5.1.1-23.fc24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-10-20 20:22:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
File: backtrace
none
File: cgroup
none
File: core_backtrace
none
File: dso_list
none
File: environ
none
File: limits
none
File: maps
none
File: mountinfo
none
File: namespaces
none
File: open_fds
none
File: proc_pid_status
none
File: var_log_messages
none
Patch - fix create_client() RPC client handling none

Description Brian J. Murrell 2016-09-29 11:10:55 UTC 
Description of problem:
Not sure how this happened

Version-Release number of selected component:
autofs-5.1.1-22.fc24

Additional info:
reporter:       libreport-2.7.2
backtrace_rating: 3
cmdline:        /usr/sbin/automount --pid-file /run/autofs.pid
executable:     /usr/sbin/automount
global_pid:     1724
kernel:         4.6.4-301.fc24.x86_64
pkg_fingerprint: 73BD E983 81B4 6521
pkg_vendor:     Fedora Project
runlevel:       N 5
type:           CCpp
uid:            0

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 ??
 #1 create_client at rpc_subs.c:657
 #2 rpc_tcp_getclient at rpc_subs.c:803
 #3 get_nfs_info at replicated.c:404
 #4 get_vers_and_cost at replicated.c:488
 #5 prune_host_list at replicated.c:717
 #6 mount_mount at mount_nfs.c:238
 #7 sun_mount at parse_sun.c:689
 #8 parse_mount at parse_sun.c:1673
 #9 lookup_mount at lookup_file.c:1293
Comment 1 Brian J. Murrell 2016-09-29 11:11:00 UTC 
Created attachment 1205914 [details]
File: backtrace
Comment 2 Brian J. Murrell 2016-09-29 11:11:00 UTC 
Created attachment 1205915 [details]
File: cgroup
Comment 3 Brian J. Murrell 2016-09-29 11:11:02 UTC 
Created attachment 1205916 [details]
File: core_backtrace
Comment 4 Brian J. Murrell 2016-09-29 11:11:03 UTC 
Created attachment 1205917 [details]
File: dso_list
Comment 5 Brian J. Murrell 2016-09-29 11:11:04 UTC 
Created attachment 1205918 [details]
File: environ
Comment 6 Brian J. Murrell 2016-09-29 11:11:05 UTC 
Created attachment 1205919 [details]
File: limits
Comment 7 Brian J. Murrell 2016-09-29 11:11:06 UTC 
Created attachment 1205920 [details]
File: maps
Comment 8 Brian J. Murrell 2016-09-29 11:11:07 UTC 
Created attachment 1205921 [details]
File: mountinfo
Comment 9 Brian J. Murrell 2016-09-29 11:11:08 UTC 
Created attachment 1205922 [details]
File: namespaces
Comment 10 Brian J. Murrell 2016-09-29 11:11:09 UTC 
Created attachment 1205923 [details]
File: open_fds
Comment 11 Brian J. Murrell 2016-09-29 11:11:10 UTC 
Created attachment 1205924 [details]
File: proc_pid_status
Comment 12 Brian J. Murrell 2016-09-29 11:11:11 UTC 
Created attachment 1205925 [details]
File: var_log_messages
Comment 13 Ian Kent 2016-09-29 11:58:49 UTC 
Do you happen to have the core file from this?

If so with some info about the update status of f24 on
the machine I might be able setup an f24 machine and
look at the core.
Comment 14 Brian J. Murrell 2016-09-29 12:03:19 UTC 
I don't I'm afraid.  I deleted the crash from the abrt-ui tool after sending the report.
Comment 15 Ian Kent 2016-09-29 13:06:11 UTC 
(In reply to Brian J. Murrell from comment #14)
> I don't I'm afraid.  I deleted the crash from the abrt-ui tool after sending
> the report.

OK.

I've been having a look at the create_client() function where
the crash occurred.

I don't understand how the crash occurred but create_client()
doesn't look quite right either.

I'll need to look at it a some more because, unfortunately, what
I do to try and minimise port usage (particularly reserved port)
is a bit complicated.
Comment 16 Ian Kent 2016-09-30 02:28:02 UTC 
Is this crash reproducible?
Comment 17 Ian Kent 2016-10-04 07:59:27 UTC 
(In reply to Ian Kent from comment #16)
> Is this crash reproducible?

Or if not how often does it happen?

We can't test a change if it doesn't happen very often.
All I can do is fix what I think is wrong in the create_client()
function and hope for the best.
Comment 18 Brian J. Murrell 2016-10-04 14:21:36 UTC 
Yeah.  I can understand that.

Perhaps leave this bug open in case any other users get an abrt about it.
Comment 19 Ian Kent 2016-10-05 00:24:37 UTC 
(In reply to Brian J. Murrell from comment #18)
> Yeah.  I can understand that.
> 
> Perhaps leave this bug open in case any other users get an abrt about it.

I can see there's a problem in create_client(), I just can't
see how it could cause the problem seen here.

What I'd prefer to do is apply the change for that, push it to
testing and for you to check that things still function as they
should, then push it to stable.

After that, close this and wait for other reports to come in,
I'll already be familiar with it from this report.

Ian
Comment 20 Fedora Update System 2016-10-13 04:52:18 UTC 
autofs-5.1.1-23.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4a81026eca
Comment 21 Ian Kent 2016-10-13 06:06:46 UTC 
(In reply to Fedora Update System from comment #20)
> autofs-5.1.1-23.fc24 has been pushed to the Fedora 24 testing repository. If
> problems still persist, please make note of it in this bug report.
> See https://fedoraproject.org/wiki/QA:Updates_Testing for
> instructions on how to install test updates.
> You can provide feedback for this update here:
> https://bodhi.fedoraproject.org/updates/FEDORA-2016-4a81026eca

Can you also test this to make sure I haven't done something
wrong that didn't show up please.
Comment 22 Ian Kent 2016-10-13 06:11:30 UTC 
Created attachment 1209918 [details]
Patch - fix create_client() RPC client handling
Comment 23 Fedora Update System 2016-10-20 20:22:00 UTC 
autofs-5.1.1-23.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.