Bug 1380381

Summary: Optimize start requests are not received properly
Product: [Retired] ovirt-optimizer Reporter: Martin Sivák <msivak>
Component: CoreAssignee: Martin Sivák <msivak>
Status: CLOSED CURRENTRELEASE QA Contact: Shira Maximov <mshira>
Severity: high Docs Contact:
Priority: high    
Version: 0.11CC: bugs, dfediuck, mavital, mgoldboi, msivak
Target Milestone: ovirt-4.0.5Flags: rule-engine: ovirt-4.0.z+
rule-engine: ovirt-4.1+
mgoldboi: planning_ack+
msivak: devel_ack+
mavital: testing_ack+
Target Release: 0.12   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-optimizer-0.12 Doc Type: Bug Fix
Doc Text:
Cause: Code issue. Consequence: The deserialization of optimize start/cancel optimization requests failed. Fix: Code fixed :) Result: The requests work now.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-01-18 07:35:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: SLA RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1386582    

Description Martin Sivák 2016-09-29 12:29:23 UTC
Description of problem:

When the user clicks the optimizer start button, optimizer fails with

Caused by: org.codehaus.jackson.map.JsonMappingException: Unexpected token (END_
OBJECT), expected FIELD_NAME: missing property '@class' that is to contain type 
id  (for class org.ovirt.optimizer.solver.facts.RunningVm)
 at [Source: io.undertow.servlet.spec.ServletInputStreamImpl@7f95760e; line: 1, 
column: 45]
        at org.codehaus.jackson.map.JsonMappingException.from(JsonMappingExcepti
on.java:163) [jackson-mapper-asl.jar:1.9.13.redhat-3]
        at org.codehaus.jackson.map.deser.StdDeserializationContext.wrongTokenEx
ception(StdDeserializationContext.java:261) [jackson-mapper-asl.jar:1.9.13.redha
t-3]
        at org.codehaus.jackson.map.jsontype.impl.AsPropertyTypeDeserializer._de
serializeTypedUsingDefaultImpl(AsPropertyTypeDeserializer.java:128) [jackson-map
per-asl.jar:1.9.13.redhat-3]


Impact:

One of the key features is not working properly.


How reproducible:

Right click stopped VM and select optimize start in the webadmin.


Additional info:

Currently configured Jackson mapping requires @class field for the incoming object. That is wrong.

Comment 1 Doron Fediuck 2016-10-05 10:46:37 UTC
Is this a dup of bug 1358794?

Comment 2 Martin Sivák 2016-10-09 18:58:28 UTC
(In reply to Doron Fediuck from comment #1)
> Is this a dup of bug 1358794?

Nope, totally unrelated.

Comment 3 Shira Maximov 2016-10-25 15:15:16 UTC
verified on :
ovirt-optimizer-0.12

verification steps: 
verify that the start optimizer is working properly