Bug 1380382

Summary: RFE: support -acpitable
Product: Red Hat Enterprise Linux 7 Reporter: Marcel Kolaja <mkolaja>
Component: libvirtAssignee: Ján Tomko <jtomko>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: high Docs Contact: Jiri Herrmann <jherrman>
Priority: high    
Version: 7.2CC: alex3kov, bloch, dyuan, ehabkost, gbailey, gklein, gmm, huding, jherrman, jsuchane, jtomko, juzhang, knoel, lersek, lhuang, lijin, lmen, lmiksik, martin, Michael, michen, mkolaja, mprivozn, mst, obockows, pbonzini, pkrempa, rbalakri, rh, rjones, s.kieske, virt-bugs, virt-maint, xfu
Target Milestone: rcKeywords: FutureFeature, ZStream
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-1.2.17-13.el7_2.6 Doc Type: Enhancement
Doc Text:
This update introduces the ability to pass an advanced configuration and power interface (ACPI) table containing system-licensed internal code (SLIC) information to a guest. To do so, add the following element to the <os> section of the guest's domain XML file, where PATHNAME is the full path name of the ACPI table file: <acpi> <table type='slic'>PATHNAME</table> </acpi> As a result, if the guest's OS previously required reactivation due to missing SLIC information (such as Microsoft Windows does), it will now be properly activated.
Story Points: ---
Clone Of: 1327537 Environment:
Last Closed: 2016-11-09 17:17:42 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1327537    
Bug Blocks:    

Description Marcel Kolaja 2016-09-29 12:35:10 UTC
This bug has been copied from bug #1327537 and has been proposed
to be backported to 7.2 z-stream (EUS).

Comment 5 lijuan men 2016-10-09 03:34:46 UTC
1.reproduce the bug
version:
libvirt-1.2.17-13.el7_2.5.x86_64
qemu-kvm-rhev-2.3.0-31.el7_2.22.x86_64

steps:
1)add the following info into the guest xml
<acpi>
      <table type='slic'>/opt/slic.dat</table>
    </acpi>

# virsh edit test
error: XML document failed to validate against schema: Unable to validate doc against /usr/share/libvirt/schemas/domain.rng
Extra element os in interleave
Element domain failed to validate content

Failed. Try again? [y,n,i,f,?]: 

2.verify the bug

version:
libvirt-1.2.17-13.el7_2.6.x86_64
qemu-kvm-rhev-2.3.0-31.el7_2.22.x86_64
kernel-3.10.0-327.42.1.el7.x86_64

steps:
1).in the host,look at the slic info
[root@localhost ~]# hexdump /root/slic.dat  -C
00000000  53 4c 49 43 24 00 00 00  01 3a 41 42 52 41 43 41  |SLIC$....:ABRACA|
00000010  44 41 42 52 41 58 59 5a  04 03 02 01 51 55 55 58  |DABRAXYZ....QUUX|
00000020  08 07 06 05                                       |....|
00000024

2).start a guest with the xml:
<os>
    <type arch='x86_64' machine='pc-i440fx-rhel7.2.0'>hvm</type>
    <acpi>
      <table type='slic'>/opt/slic.dat</table>
    </acpi>
    <boot dev='hd'/>
  </os>

3).In the guest,run "acpidump"
#acpidump
...
SLIC @ 0x0000000000000000
  0000: 53 4C 49 43 24 00 00 00 01 3A 41 42 52 41 43 41  SLIC$....:ABRACA
  0010: 44 41 42 52 41 58 59 5A 04 03 02 01 51 55 55 58  DABRAXYZ....QUUX
  0020: 08 07 06 05                                      ....

Comment 6 Laszlo Ersek 2016-10-12 14:59:43 UTC
s/PATH/PATHNAME in the doc text -- Jirka (Herrmann), can you please review it? Thanks.

Comment 8 errata-xmlrpc 2016-11-09 17:17:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2688.html