| Summary: | Disable node functionality in virtualization dashboard if nodectl is not available | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-node | Reporter: | Fabian Deutsch <fdeutsch> | ||||
| Component: | UI | Assignee: | Ryan Barry <rbarry> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Wei Wang <weiwang> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.0 | CC: | bugs, dguo, jcall, rbarry, sbonazzo, ycui | ||||
| Target Milestone: | ovirt-4.1.0-beta | Keywords: | Reopened | ||||
| Target Release: | 4.1 | Flags: | rule-engine:
ovirt-4.1+
rule-engine: blocker+ rule-engine: planning_ack+ fdeutsch: devel_ack+ ycui: testing_ack+ |
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | cockpit-ovirt-0.10.7-0.0.4.el7ev | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-02-15 14:52:36 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Node | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1346835 | ||||||
| Attachments: |
|
||||||
|
Description
Fabian Deutsch
2016-09-30 08:48:30 UTC
This leaves the dashboard relatively rare. Unless I've missed something, the goal on non-Node hosts is to not use the "dashboard" page at all, but to present only "Hosted Engine" and "Virtual Machines". *** This bug has been marked as a duplicate of bug 1346835 *** It seems that we'll ship the dashboard on RHEL-H, so re-opening this. *** Bug 1378412 has been marked as a duplicate of this bug. *** I have to reopen this bug, tested failed on cockpit-ovirt-dashboard-0.10.7-0.0.3.el7ev.noarch on RHEL 7.3 host. Steps to Reproduce: 1. Installed the cockpit-ovirt-dashboard plugin in regular hosts(RHEL 7.3) 2. Accessed cockpit UI by _root_ account. 3. Navigated to Virtualization Dashboard in Cockpit UI. 4. Checking Node Status UI. Actual results: 1. Node status is always with spinner icon, and display "Can't check node status! Please run as an administrator!" Expected results: ovirt-node-ng-nodectl is for RHVH only, so here should not show Node status in cockpit-ovirt-dashbaord in regular hosts. This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP. Created attachment 1243513 [details]
screenshot_cockpit-ovirt-dashboard
*** Bug 1415562 has been marked as a duplicate of this bug. *** This was merged upstream and needs a new build to include it. This also cannot be a regression, since the appropriate patch missed cherry picking to ovirt-4.1, and was only present in master until Jan 12th. (In reply to Ryan Barry from comment #12) > This was merged upstream and needs a new build to include it. > > This also cannot be a regression, since the appropriate patch missed cherry > picking to ovirt-4.1, and was only present in master until Jan 12th. Confirmed with team for comment #4 #5 #6, then it is not regression, team missed checking the dashboard UI in regular host. Test Version fedora-release-server-24-1.noarch kernel-4.5.5-300.fc24.x86_64 cockpit-0.103-1.fc24.x86_64 cockpit-ovirt-dashboard-0.10.7-0.0.6.fc24.noarch vdsm-4.19.4-1.fc24.x86_64 Test Steps: 1. Clean install Fedora24 2. dnf install http://resources.ovirt.org/pub/yum-repo/ovirt-release41-pre.rpm 3. dnf install cockpit-ovirt-dashboard.noarch 4. Login cockpit webUI with root account 5. Go to "Virtualization", check "Dashboard" page Result: The "Dashboard" page exists. According to comment #1, the bug can be reproduced, change status to ASSIGNED Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Ryan, According to comment #1, the solution is to disable "Dashboard" page for the regular host with cockpit-ovirt plugin. But from patch, the solution only make nodectl disabled. Could you please tell us which one is the right one? See comment#2. We are actually shipping a dashboard page, just without any of the node functionality on it (so there should only be links back to "Networking", "Storage", and other base cockpit pages). For Fedora24 server, the bug cannot be reproduced. Version fedora-release-server-24-1.noarch kernel-4.5.5-300.fc24.x86_64 cockpit-0.103-1.fc24.x86_64 cockpit-ovirt-dashboard-0.10.7-0.0.6.fc24.noarch vdsm-4.19.4-1.fc24.x86_64 Steps: 1. Clean install Fedora24 2. dnf install http://resources.ovirt.org/pub/yum-repo/ovirt-release41-pre.rpm 3. dnf install cockpit-ovirt-dashboard.noarch 4. Login cockpit webUI with root account 5. Go to "Virtualization"-->"Dashboard", check node status is disabled 6. Check nodectl in console #nodectl -h Results: The nodectl depending informations are hidden. # nodectl -h -bash: nodectl: command not found For Centos7.3 server, the bug cannot be reproduced. Version centos-release-7-3.1611.el7.centos.x86_64 kernel-3.10.0-514.el7.x86_64 cockpit-126-1.el7.centos.x86_64 cockpit-ovirt-dashboard-0.10.7-0.0.6.el7.centos.noarch vdsm-4.19.4-1.el7.centos.x86_64 Steps: 1. Clean install Centos73 2. yum install http://resources.ovirt.org/pub/yum-repo/ovirt-release41-pre.rpm 3. yum install cockpit 4. yum install cockpit-ovirt-dashboard.noarch 6. Config firewall with cockpit 7. Login cockpit webUI with root account 8. Go to "Virtualization"-->"Dashboard", check node status is disabled 9. Check nodectl in console #nodectl -h Results: The nodectl depending informations are hidden. # nodectl -h -bash: nodectl: command not found For RHEL7.3 server, the bug cannot be reproduced. Version: redhat-release-server-7.3-7.el7.x86_64 kernel-3.10.0-514.el7.x86_64 cockpit-126-1.el7.x86_64 cockpit-ovirt-dashboard-0.10.7-0.0.6.el7ev.noarch vdsm-4.19.4-1.el7ev.x86_64 Steps: 1. Clean install RHEL7.3 2. yum install http://bob.eng.lab.tlv.redhat.com/builds/latest_4.1/rhv-release-latest-4.1.noarch.rpm 3. yum install cockpit 4. yum install cockpit-ovirt-dashboard 5. Login cockpit webUI with root account 6. Go to "Virtualization"-->"Dashboard", check node status is disabled 7. Check nodectl in console #nodectl -h Results: The nodectl depending informations are hidden. # nodectl -h -bash: nodectl: command not found The bug is verified with Fedora24/Centos7.3/RHEL7.3 host. Change status to VERIFIED. |