Bug 1380698

Summary: Use lvm backup options only for commands that needs this option
Product: [oVirt] vdsm Reporter: Nir Soffer <nsoffer>
Component: CoreAssignee: Nir Soffer <nsoffer>
Status: CLOSED WONTFIX QA Contact: Elad <ebenahar>
Severity: low Docs Contact:
Priority: low    
Version: 4.18.0CC: bugs, ebenahar, nsoffer, tnisan, ylavi, zkabelac
Target Milestone: ---Flags: sbonazzo: ovirt-4.3-
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-09-03 08:25:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Output of grep ' backup ' on vdsm log in debug mode none

Description Nir Soffer 2016-09-30 11:14:30 UTC
Created attachment 1206224 [details]
Output of grep ' backup ' on vdsm log in debug mode

Description of problem:

Vdsm uses --config 'backup { ... }' options for read only lvm commands that do not
need this option. This works since the commands ignore this option, but add noise
to vdsm log and make it harder to debug.

Example commands with unneeded backup options:

- vgs
- vgck

See backup.log.

There may be more commands with this issue.

Version-Release number of selected component (if applicable):
All

How reproducible:
Always

Steps to Reproduce:
1. Look in vdsm logs in DEBUG mode for lvm commands run by vdsm.

Actual results:
backup option used in read only commands

Expected results:
backup option used only in commands that may create a backup

Comment 1 Nir Soffer 2016-09-30 11:17:24 UTC
Zdenek, do we have a list of commands that needs this option, or we should just use
this on commands that mention the backup options in the manual?

$ man lvchange | grep backup
       tionPolicy] [-A|--autobackup {y|n}] [--cachepolicy policy] [--cachesettings key=value] [--commandprofile ProfileName] [-C|--contiguous {y|n}] [-d|--debug] [--degraded] [--deltag

Comment 2 Zdenek Kabelac 2016-09-30 11:37:16 UTC
There are more question to ask first:

1. Would there there be a plan to use this without locking_type=4 ?


2. There would be no point to configure backups on 'hosts' when executed command should be purely read-only  (locking_type=4).

Comment 3 Nir Soffer 2017-03-06 22:23:45 UTC
Removing old need infos.

Comment 4 Tal Nisan 2018-09-03 08:25:09 UTC
Closing old bugs, reopen if still needed.