| Summary: | ManageIQ Region shows instead of CFME Region in Configuration menu | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Oleksii Tsuman <otsuman> | ||||
| Component: | UI - OPS | Assignee: | Dávid Halász <dhalasz> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Oleksii Tsuman <otsuman> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.7.0 | CC: | akarol, anewman, cpelland, dajohnso, hkataria, jhardy, lcouzens, mmojzis, mpovolny, mzazrivec, nansari, obarenbo, sbulage | ||||
| Target Milestone: | GA | Keywords: | TestOnly | ||||
| Target Release: | 5.8.0 | Flags: | otsuman:
automate_bug+
|
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | ui:region | ||||||
| Fixed In Version: | 5.8.0.0 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1395842 (view as bug list) | Environment: | |||||
| Last Closed: | 2017-06-12 16:23:28 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1395842 | ||||||
| Attachments: |
|
||||||
David, This was introduced by changes in https://github.com/ManageIQ/manageiq/pull/11267. I think the best way to do this is use dictionary lookup so we can have different string showing on upstream/downstream. In my opinion you can use I18n.t('product.name') instead of hard-coding the string. Let me know if you have questions. Thanks, ~Harpreet Milan, please suggest if this should be handled differently. Yes, I agree with the I18n.t('product.name') thing.
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/9b7c3e7edaf2aa20cee3dc2e96b977f3d3ca91e1 commit 9b7c3e7edaf2aa20cee3dc2e96b977f3d3ca91e1 Author: Dávid Halász <dhalasz> AuthorDate: Mon Oct 3 11:27:24 2016 +0200 Commit: Dávid Halász <dhalasz> CommitDate: Mon Oct 3 16:25:48 2016 +0200 Changed ManageIQ to I18n('product.name') in gettext calls https://bugzilla.redhat.com/show_bug.cgi?id=1380781 app/controllers/application_controller.rb | 10 +-- .../application_controller/ci_processing.rb | 37 +++++----- app/controllers/application_controller/filter.rb | 2 +- app/controllers/ems_common.rb | 79 ++++++++++++---------- app/controllers/miq_ae_tools_controller.rb | 4 +- app/controllers/miq_policy_controller.rb | 4 +- app/controllers/miq_task_controller.rb | 18 ++--- app/controllers/ops_controller/diagnostics.rb | 20 +++--- app/controllers/ops_controller/settings/common.rb | 12 ++-- app/controllers/ops_controller/settings/upload.rb | 2 +- app/controllers/storage_manager_controller.rb | 6 +- app/controllers/vm_common.rb | 4 +- app/models/miq_server/update_management.rb | 2 +- app/presenters/tree_builder_ops_diagnostics.rb | 5 +- app/presenters/tree_builder_ops_rbac.rb | 5 +- app/presenters/tree_builder_ops_settings.rb | 5 +- app/presenters/tree_builder_utilization.rb | 5 +- app/services/user_validation_service.rb | 4 +- app/views/layouts/_x_edit_buttons.html.haml | 4 +- app/views/ops/_all_tabs.html.haml | 2 +- app/views/ops/rhn/_server_table.html.haml | 4 +- .../application_controller/ci_processing_spec.rb | 4 +- .../controllers/ops_controller/diagnostics_spec.rb | 2 +- spec/controllers/vm_infra_controller_spec.rb | 12 ++-- 24 files changed, 133 insertions(+), 119 deletions(-) *** Bug 1381177 has been marked as a duplicate of this bug. *** *** Bug 1381501 has been marked as a duplicate of this bug. *** *** Bug 1381645 has been marked as a duplicate of this bug. *** *** Bug 1381226 has been marked as a duplicate of this bug. *** *** Bug 1382346 has been marked as a duplicate of this bug. *** verified in 5.8.0.2.20170223184827_489bf7c |
Created attachment 1206301 [details] screenshot Description of problem: In configuration menu instead of CFME Region present ManageIQ Region Version-Release number of selected component (if applicable): Version 5.7.0.3.20160927165516_075d0f3 How reproducible: Steps to Reproduce: 1. Go to Configuration tab Actual results: ManageIQ Region shown Expected results: CFME Region shown Additional info: