Bug 1380850

Summary:	atomic containers delete <NULL> silently succeeds
Product:	Red Hat Enterprise Linux 7	Reporter:	Chris Evich <cevich>
Component:	atomic	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:	atomic-bugs <atomic-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.3	CC:	ajia, dwalsh
Target Milestone:	rc	Keywords:	Extras
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-12-06 17:42:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Evich 2016-09-30 19:02:09 UTC

Description of problem:


Version-Release number of selected component (if applicable):
docker-1.10.3-55.el7.x86_64
atomic-1.12.3-2.el7.x86_64

How reproducible:
trivial

Steps to Reproduce:
1. # atomic containers delete $(echo -e "\000")

Actual results:
(no output)
(exit code 0)

Expected results:
Some kind of 'invalid', 'missing', or 'unknown' argument message and a non-zero exit.

Additional info:

Comment 2 Alex Jia 2016-10-10 08:49:22 UTC

The same issue in atomic-1.12.5-2.el7.x86_64.

Comment 3 Daniel Walsh 2016-10-10 15:01:25 UTC

https://github.com/projectatomic/atomic/pull/689 should fix this.

Comment 4 Daniel Walsh 2016-10-12 19:04:45 UTC

Fixed in atomic-1.13

Comment 6 Alex Jia 2016-10-28 09:29:51 UTC

I can get an expected result like the following error now.

[root@atomic-host-001 cloud-user]# atomic containers delete $(echo -e "\000")
Expected a string but found [None] (<type 'list'>) instead

[root@atomic-host-001 cloud-user]# atomic host status
State: idle
Deployments:
● rhel-atomic-host:rhel-atomic-host/7/x86_64/standard
       Version: 7.3 (2016-10-26 14:24:09)
        Commit: 90c9735becfff1c55c8586ae0f2c904bc0928f042cd4d016e9e0e2edd16e5e97
        OSName: rhel-atomic-host
  GPGSignature: (unsigned)
      Unlocked: development

[root@atomic-host-001 cloud-user]# rpm -q atomic
atomic-1.13.3-1.el7.x86_64

Comment 8 errata-xmlrpc 2016-12-06 17:42:12 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2857.html